Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name, topic and membership changes on Discord. #164

Merged
merged 6 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@Half-Shot
Copy link
Owner

commented Jun 11, 2018

Fixes #155

This just consumes state events and sends a message from the bot into the bridged channel.

@Sorunome

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2018

why not attempt to set name / topic on the discord side, with fallback to what you have in there? Perhaps the bot has name / topic setting permissions after all

@Sorunome Sorunome added the feature label Jul 26, 2018

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 28, 2018

Hmm, I think it would need to be a setting to ensure we don't accidentally overwrite something by accident. Also if you are double bridging IRC or Twitter, it could be trouble. I think the idea behind this PR was to show something to the users.

More settings for provisioning, like a "!track topic/name" would be 👍

@Sorunome

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2018

More settings for provisioning, like a "!track topic/name" would be 👍

That kinda goes into #206

So, if i understand it correctly, what i suggested is out-of-scope of this PR?

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 30, 2018

So, if i understand it correctly, what i suggested is out-of-scope of this PR?

For now, yes. We'd want to do this properly and that time will come when we can setup proper provisioning settings :)

Sorunome added some commits Aug 1, 2018

const msg = processor.StateEventToMessage(event, channel as any);
Chai.assert.equal(msg, undefined);
});
it("Should set name changes", () => {

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Aug 1, 2018

Author Owner

small nit: "set" is probably the wrong word for these. I'd prefer echo or report

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Aug 1, 2018

Almost there!

@Half-Shot Half-Shot merged commit 1c45ea6 into develop Aug 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Sorunome Sorunome deleted the hs/show-state-events branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.