Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom keys for discord member #175

Merged
merged 4 commits into from Jul 30, 2018

Conversation

Projects
None yet
2 participants
@Half-Shot
Copy link
Owner

commented Jul 9, 2018

Another request from /dev/ponies, this is adding a few custom keys from discord into the member object.

Fixes #173

@Half-Shot Half-Shot added the feature label Jul 9, 2018

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 16, 2018

#142 will have broken this

Sorunome added some commits Jul 30, 2018

@@ -218,6 +225,11 @@ export class UserSyncroniser {
const guildState = Object.assign({}, DEFAULT_GUILD_STATE, {
id: newMember.id,
mxUserId: `@_discord_${newMember.id}:${this.config.bridge.domain}`,
roles: newMember.roles.map((role) => { return {

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Jul 30, 2018

Author Owner

This can be shortened to

newMember.roles.map((role) => {
                name: role.name,
                color: role.color,
                position: role.position,
})

I believe

This comment has been minimized.

Copy link
@Sorunome

Sorunome Jul 30, 2018

Collaborator

Doesn't seem so, unfortunately (I just tried)

(as in, typescript won't compile with that)

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Jul 30, 2018

Author Owner

Really, oh well. I thought that worked :|

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 30, 2018

Tests look 👌 Just one question on it.

@Sorunome Sorunome referenced this pull request Jul 30, 2018

Merged

Soru/usernamefix #194

@Half-Shot Half-Shot merged commit 35cde48 into develop Jul 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Sorunome Sorunome deleted the hs/extra-member-keys branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.