Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npmlog with winston #182

Merged
merged 13 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@Half-Shot
Copy link
Owner

commented Jul 19, 2018

No description provided.

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 22, 2018

I think this PR is ready, pending review from interested parties.

But I'm holding off until we have the major PRs merged because of the conflicts.

@turt2live

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2018

I would have settled for timestamps, but this is much more interesting :D

It would be nice to be able to disable file logging entirely and instead opt for console logging. This is in particularly useful for Docker containers which don't need the logs duplicated.

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 22, 2018

It would be nice to be able to disable file logging entirely and instead opt for console logging. This is in particularly useful for Docker containers which don't need the logs duplicated.

It does that by default?

More helpfully: Unless you specify files, it will log to console. Unless you set console to silent.

Half-Shot added some commits Jul 30, 2018

@Sorunome
Copy link
Collaborator

left a comment

While I didn't look through every single log.xxx() change, i did check the log.ts and stuff and it looks good to me! 👍

@Half-Shot

This comment has been minimized.

Copy link
Owner Author

commented Jul 30, 2018

Yaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaymergeddddd

@Half-Shot Half-Shot merged commit b9c7a01 into develop Jul 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Half-Shot Half-Shot referenced this pull request Jul 30, 2018

Closed

Add timestamps to logs #166

@Sorunome Sorunome deleted the hs/winston branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.