Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibacked support for databases #251

Merged
merged 10 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@Half-Shot
Copy link
Owner

commented Oct 23, 2018

This is a PR to attempt to escape node-sqlite3, which is no longer building reliably. This also starts work on making generic connectors rather than a single database instance by creating a connector class.

I've gotten the tests to pass but can't be sure this is working 100% yet, testers welcome!

EDIT: Due to feature creeping the hell out of this, it now supports postgres too! I know right!

Also I got fed up of npmlog and removed it from all the leftover places.

Fixes #158, #245.

@Half-Shot Half-Shot changed the title Hs/better sqlite3 better-sqlite3 support Oct 23, 2018

@Half-Shot Half-Shot changed the title better-sqlite3 support Multibacked support for databases Oct 23, 2018

@turt2live

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2018

Migration steps would be nice too :)

@Half-Shot Half-Shot merged commit fbbf92e into develop Oct 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@Half-Shot Half-Shot deleted the hs/better-sqlite3 branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.