New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winner determined incorrectly #148

Closed
lidavidm opened this Issue Nov 14, 2018 · 3 comments

Comments

Projects
None yet
2 participants

@lidavidm lidavidm self-assigned this Nov 14, 2018

@lidavidm

This comment has been minimized.

Copy link
Contributor Author

lidavidm commented Nov 14, 2018

@0Zeta

This comment has been minimized.

Copy link

0Zeta commented Nov 23, 2018

From the halite website: "If a player does not have a ship or enough energy to construct a ship, they are considered “dead” and lose the game." Probably the game ends because of both players having no ships left before the dropped halite is added to the player´s halite amount. But indeed changing the game logic so the other player would have won the game would make sense.

lidavidm pushed a commit that referenced this issue Nov 23, 2018

@lidavidm

This comment has been minimized.

Copy link
Contributor Author

lidavidm commented Nov 23, 2018

@0Zeta yup, pretty much. Fix is simple enough but needs some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment