New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully spawn a ship even when it immediately crashes. #173

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@Janzert
Copy link
Collaborator

Janzert commented Dec 2, 2018

This change is a potential fix for #172 and makes the engine actually spawn a ship even when it immediately crashes into an existing ship. This allows all events to occur and fixes the all_collisions and self_collisions counts in the player statistics.

One part I'm unsure of with this change is that it causes entity_updated to be called before cell.entity is set.

Even with this change the visualizer collision count when watching a replay is still incorrect. I haven't looked into why that is yet.

@Janzert Janzert requested a review from lidavidm Dec 2, 2018

@lidavidm
Copy link
Contributor

lidavidm left a comment

Moving entity_updated should be fine; it's only used to track what entities are allowed to mine this turn.

@lidavidm lidavidm merged commit 7776824 into HaliteChallenge:master Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment