New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a starter kit for Ruby #30

Merged
merged 5 commits into from Oct 23, 2018

Conversation

Projects
None yet
6 participants
@jenheilemann
Contributor

jenheilemann commented Oct 17, 2018

Essentially a straight translation of the Python kit to Ruby. Fixes issue #2.

@jenheilemann jenheilemann force-pushed the jenheilemann:master branch from 83921e7 to 12fc22e Oct 18, 2018

@GrahamMThomas

This comment has been minimized.

GrahamMThomas commented Oct 18, 2018

Thank you so much for writing this.

@jenheilemann jenheilemann force-pushed the jenheilemann:master branch from 12fc22e to de89fab Oct 18, 2018

@jenheilemann jenheilemann force-pushed the jenheilemann:master branch from de89fab to 5873d66 Oct 18, 2018

@GrahamMThomas

This comment has been minimized.

GrahamMThomas commented Oct 19, 2018

+1

Been using this for a while and haven't run into anymore issues

@jenheilemann jenheilemann force-pushed the jenheilemann:master branch from 5873d66 to a54c346 Oct 20, 2018

@lidavidm

This comment has been minimized.

Contributor

lidavidm commented Oct 23, 2018

@whatelsie @snaar seems like the kit works, should we merge it?

end
# Converts from this direction tuple notation to the engine's string notation
# :param direction: the direction in this notation

This comment has been minimized.

@BobbyMcWho

BobbyMcWho Oct 23, 2018

Contributor

non-blocking
Nitpick: These comments are yanked from the python version, and not of proper Ruby YARD doc style. I'll open an issue to resolve once this is merged.

@@ -0,0 +1,12 @@
# All viable commands that can be sent to the engine

This comment has been minimized.

@snaar

snaar Oct 23, 2018

Contributor

This is not technically correct, since now you have cardinals there as well, they are not commands per-se. But I can live with it.

@snaar snaar merged commit c4474d1 into HaliteChallenge:master Oct 23, 2018

@snaar snaar referenced this pull request Oct 23, 2018

Closed

Add Ruby Starter #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment