Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suzu: Add manifest for Sony Xperia X #116

Merged
merged 11 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@fredldotme
Copy link
Contributor

commented Sep 7, 2018

This manifest replaces and removes some default repositories:

  • Removal of Qualcomm SELinux policies
  • bionic: Support for loading binaries and libraries from /odm
  • Qualcomm display HAL: Added "(AOSP)" suffix
  • Qualcomm Dataservices: AOSP build

@fredldotme fredldotme referenced this pull request Sep 7, 2018

Open

[device-port] [suzu] Sony Xperia X #98

23 of 33 tasks complete
@JBBgameich

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

I'll have a more carful look at your changes later, but would it be possible to pull request your changes to the repositories you forked from Halium instead of replacing the repo with a fork?

@fredldotme

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2018

The required Android bionic is still awaiting pull approval.
Halium/android_bionic#5

The HAL driver author suffix "AOSP" is currently required for Mir to load the non-CAF graphics platform.

fredldotme added some commits Sep 11, 2018

sony_suzu: Rename kernel repo
device-kernel-suzu => device-kernel-loire
sony_suzu: Switch back to Halium bionic
All required changes for /odm support are now merged.
sony_suzu: Use default dataservices
No need to diverge from other Halium implementations.
@fredldotme

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2018

We've since switched back to Halium's bionic as the necessary changes have been merged.

@JBBgameich

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

Looks almost fine now, but can you please apply the formatting that is used in the other manifests before merging?

sony_suzu: Formatting and halium-install script
Apply proper formatting for xml and include halium-install repo for quickly installing resulting images.
@JBBgameich

This comment has been minimized.

Copy link
Member

commented Sep 15, 2018

The remotes are usually written in multiple lines. Just have a look at the other manifests for inspiration :)
Also, please don't include the halium-install script into the device manifest. If you want it to be included, please create a pull request at the main manifest repo. (The script is not device specific)

fredldotme added some commits Sep 19, 2018

sony_suzu: Remove halium-install and reorganize
We require a fork of android_system_sepolicy for now.
@fredldotme

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

Reorganized a little, should be conform now.
I had to add a custom sepolicy repo with sdcard and exfat SELinux policy generation deactivated. The compile time switch wasn't working so I had to
revert the commit which introduced this behaviour.
Nothing special and only necessary as Halium distributions typically don't use Android's vold anyway.

Kind hint that, should those new repos require to be maintained under the Halium umbrella, you can count me in.

@JBBgameich JBBgameich merged commit f734100 into Halium:halium-7.1 Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.