Add Nexus 6P (angler) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a manifest for Nexus 6P (huawei_angler).
Placed in incorrect directory
Adds manifest for Nexus 6P (huawei_angler)
|
You'll have to comment out the apk targets in the vendor repository locally. We don't want to fork these repositories, so currently there is no way to fix this. But we're planning to add patches in this repository, that will be applied using the setup script. If this is the only issue, then we can merge it. |
|
With the apk targets commented out, |
|
I think you forgot to run lunch / breakfast |
|
UPDATE: Running |
|
Before you can do breakfast, you always have to setup your build environment: |
|
So far, |
|
Did you update the kernel config as described in the guide? |
|
Yes, I have. Here's the kernel config: |
|
I have now been able to successfully execute Other than that, Halium builds fine. |
16 tasks
lnjX
reviewed
Feb 6, 2018
manifests/huawei_angler.xml
Outdated
| @@ -0,0 +1,5 @@ | |||
| <manifest> | |||
| <project path="device/huawei/angler" name="android_device_huawei_angler" remote="los" revision="cm-14.1" /> | |||
lnjX
reviewed
Feb 6, 2018
manifests/huawei_angler.xml
Outdated
| <manifest> | ||
| <project path="device/huawei/angler" name="android_device_huawei_angler" remote="los" revision="cm-14.1" /> | ||
| <project path="kernel/huawei/angler" name="android_kernel_huawei_angler" remote="los" /> | ||
| <project path="vendor/huawei" name="proprietary_vendor_huawei" remote="them" /> |
There was a problem hiding this comment.
Please use the hal remote and the halium-7.1 branch in all repositories you have made modifications to.
Repo references changed to Halium-appropriate repositories
|
I changed the repository references to those that were modified for Halium. However, I don't think that I can use the |
|
You can use the hal remote, it doesn't include a organization name. |
Changes remote repo references to `hal`.
|
@jbbgameich, I've made the changes to the manifest that you and @LNJ2 suggested. |
lnjX
reviewed
Feb 7, 2018
manifests/huawei_angler.xml
Outdated
| <manifest> | ||
| <project path="device/huawei/angler" name="android_device_huawei_angler" remote="los" /> | ||
| <project path="kernel/huawei/angler" name="android_kernel_huawei_angler" remote="hal" revision="halium-7.1" /> | ||
| <project path="vendor/huawei" name="proprietary_vendor_huawei" remote="hal" revision="halium-7.1" /> |
There was a problem hiding this comment.
halium-7.1 revision attribute is not needed on the hal remote.
Please omit the revision attribute
And the vendor repository shouldn't be forked? Did you made any changes?
There was a problem hiding this comment.
The vendor and kernel repos were forked from TheMuppets and LineageOS respectively because of Halium-specific changes; do I need to merge the changes to Halium?
There was a problem hiding this comment.
Kernel repository is fine! I know that there are currently problems with the vendor repository, halium doesn't want these forks (it's partly not allowed to redistribute the proprietary drivers). But we could apply patches to them from the muppets.
So please use the them remote for the vendor repo and omit the revision attributes in both repositories, kernel and vendor (halium-7.1 is the default branch of the hal remote and cm-14.1 of them).
Remote repository references for the kernel and vendor were reverted to `hal` and `them` respectively. Additionally, the branch reference `halium-7.1` was removed from both since it was unnecessary.
win8linux
commented
Feb 9, 2018
lnjX
reviewed
Feb 9, 2018
manifests/huawei_angler.xml
Outdated
| @@ -0,0 +1,5 @@ | |||
| <manifest> | |||
| <project path="device/huawei/angler" name="android_device_huawei_angler" remote="los" /> | |||
| <project path="kernel/huawei/angler" name="android_kernel_huawei_angler" remote="hal" /> | |||
There was a problem hiding this comment.
Sorry for another commet, but have you tested it? I don't think this can work, the hal remote expects an github-username/repository, instead of just the repository.
There was a problem hiding this comment.
Something like:
path="win8linux/kernel/huawei/angler"
or
path="win8linux/android_kernel_huawei_angler"?
Also, I can't test this yet myself since my main machine is in the computer shop at the moment; I'm having the hard disk swapped out for one with twice the capacity and the data migration is going to take a while.
Until then, I'll be using a spare netbook; it's way too slow for building Halium in a reasonable timeframe.
|
Thanks! |
drgroovestarr
pushed a commit
to drgroovestarr/vendor_huawei
that referenced
this pull request
Jan 26, 2019
halium does not build apks, reference : Halium/halium-devices#37 (comment)
drgroovestarr
pushed a commit
to drgroovestarr/vendor_huawei
that referenced
this pull request
Jan 26, 2019
halium does not build apks, reference : Halium/halium-devices#37 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the time of posting this, the system image fails to build.
Here's the output from
mka systemimage:However, building
hybris-bootand the boot image are both successful.