Remove init-system specific options (fixes upstart) #21

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
Member

JBBgameich commented Dec 18, 2017

According to @UniversalSuperBox research, upstart doesn't support the --log-target=kmsg option. After a small discussion in the UBports group, @mariogrip and @bhush9 came to the conclusion that the option is useless anyway. So let's remove it.

@JBBgameich JBBgameich changed the title from (Probably) fix upstart support to Remove init-system specific options (fixes upstart) Dec 19, 2017

@JBBgameich JBBgameich requested a review from bhush9 Dec 19, 2017

bhush9 approved these changes Dec 19, 2017

Please squash/edit commit message according to comment on tg.

init-script
@@ -345,7 +345,7 @@ if [ "$DONE_SWITCH" = "no" ]; then
else
# Prefer /sbin/preinit over /sbin/init
[ -x /target/sbin/preinit ] && INIT=/sbin/preinit || INIT=/sbin/init
- exec switch_root /target $INIT --log-target=kmsg &> /target/init-stderrout
+ exec switch_root /target $INIT /target/init-stderrout
@mariogrip

mariogrip Dec 19, 2017

Owner

Are you sure you want to remove &>?

@JBBgameich

JBBgameich Dec 19, 2017

Member

sorry ... fixed

@JBBgameich JBBgameich merged commit 1c260f0 into Halium:master Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment