Fix a crash in hs.menubar caused by improper placement of a Lua stack…

…guard exit call. Closes #1746
Hammerspoon · Apr 12, 2018 · 95a1355 · 95a1355
1 parent 93d4bfa
commit 95a1355
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/extensions/menubar/internal.m b/extensions/menubar/internal.m
@@ -184,8 +184,8 @@ - (void) click:(id)sender {
     [self callback_runner];
     // error or return value (ignored in this case), we gotta cleanup
     lua_pop(self.L, 1) ;
-    myDelegate = nil ;
     _lua_stackguard_exit(self.L);
+    myDelegate = nil ; // NOTE: DO NOT USE `self` AFTER THIS POINT, IT WILL HAVE BEEN DEALLOCATED.
 }
 @end