Fix a crash in hs.menubar caused by improper placement of a Lua stackguard exit call. Closes #1746

cmsj · cmsj · commit 95a13554c655 · 2018-04-12T19:58:06.000+01:00
diff --git a/extensions/menubar/internal.m b/extensions/menubar/internal.m
@@ -184,8 +184,8 @@ - (void) click:(id)sender {
     [self callback_runner];
     // error or return value (ignored in this case), we gotta cleanup
     lua_pop(self.L, 1) ;
-    myDelegate = nil ;
     _lua_stackguard_exit(self.L);
+    myDelegate = nil ; // NOTE: DO NOT USE `self` AFTER THIS POINT, IT WILL HAVE BEEN DEALLOCATED.
 }
 @end
 

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,8 @@ - (void) click:(id)sender {`
`184`	`184`	`[self callback_runner];`
`185`	`185`	`// error or return value (ignored in this case), we gotta cleanup`
`186`	`186`	`lua_pop(self.L, 1) ;`
`187`		`- myDelegate = nil ;`
`188`	`187`	`_lua_stackguard_exit(self.L);`
	`188`	+ myDelegate = nil ; // NOTE: DO NOT USE `self` AFTER THIS POINT, IT WILL HAVE BEEN DEALLOCATED.
`189`	`189`	`}`
`190`	`190`	`@end`
`191`	`191`