Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Today's commits broke building on 10.14.6 #2136

Closed
chdiza opened this issue Aug 15, 2019 · 6 comments

Comments

@chdiza
Copy link

commented Aug 15, 2019

I just tried building 9e6a0c8 after a git pull. I did make release as usual and got:

/opt/bld/hammerspoon/LuaSkin/LuaSkin/Skin.m:280:32: error: unknown warning group '-Wsizeof-pointer-div', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wsizeof-pointer-div"
                               ^
/opt/bld/hammerspoon/LuaSkin/LuaSkin/Skin.m:322:32: error: unknown warning group '-Wsizeof-pointer-div', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wsizeof-pointer-div"
                               ^
2 errors generated.

I had to mine this out of Release-build.log. What showed in the terminal was:

The following build commands failed:
	CompileC /Users/chdiza/Library/Developer/Xcode/DerivedData/Hammerspoon-adlzscacpnutjgcpsrpwvdewubqc/Build/Intermediates.noindex/LuaSkin.build/Release/LuaSkin.build/Objects-normal/x86_64/Skin.o /opt/bld/hammerspoon/LuaSkin/LuaSkin/Skin.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
make: *** [build/Hammerspoon.app] Error 65
@latenitefilms

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

You need to use Xcode 11 Beta 5, or comment out those lines.

@cmsj

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Yeah I’m getting us ready for xcode11 and Catalina.

@cmsj cmsj closed this Aug 15, 2019

@chdiza

This comment has been minimized.

Copy link
Author

commented Aug 15, 2019

Does this mean that HS will from now on only be buildable on Xcode11 (and thus, only on Mojave or greater)? Or is this just some initial tinkering?

@cmsj

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@chdiza This isn't tinkering, I'm getting everything in order for Catalina and Xcode 11 releasing, which typically includes going over any new build warnings and fixing them.

Are you building on something older than Mojave?

@chdiza

This comment has been minimized.

Copy link
Author

commented Aug 15, 2019

I'm getting everything in order for Catalina and Xcode 11 releasing, which typically includes going over any new build warnings and fixing them.

That's all I meant by "tinkering" :) I was just wondering if the inability to build on a pre-Mojave or pre-Xcode11 setup is going to be permanent, or is rather just a temporary side effect of testing-and-getting-ready.

Are you building on something older than Mojave?

On my High Sierra machines, yes. On my Mojave machine, no.

@asmagill

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@cmsj, do you know of any way to determine at compile time if certain warnings exist for the local version of clang and branch around the two pragma's identified above? At present, these two lines are the only things preventing Hammerspoon from building under the latest non-beta of XCode... for now I'm just removing them (and then making sure to discard my changesto Skin.m before pushing anything into a pull request, but it would be nice if some sort of test for warnings existed in clang like feature tests do so I didn't have to...

Not a biggie, I believe being proactive wrt to the upcoming OS update is more important than my convenience, but that doesn't mean I wouldn't prefer to eat my cake along with having it too 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.