Skip to content

Extended hs.osascript with functions to execute as/js from a file#1616

Closed
rkalis wants to merge 1 commit into
Hammerspoon:masterfrom
rkalis:master
Closed

Extended hs.osascript with functions to execute as/js from a file#1616
rkalis wants to merge 1 commit into
Hammerspoon:masterfrom
rkalis:master

Conversation

@rkalis

@rkalis rkalis commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

This allows people to import an AppleScript file to execute, instead of writing it inline in a Lua file. This also makes it easier to debug these scripts before integrating it with Hammerspoon as the files can be run separately first.

…mFile functions, which import apple/javascript from a file, and exefcute it using the existing osascript functions
--- Returns:
--- * A boolean value indicating whether the code succeeded or not
--- * An object containing the parsed output that can be any type, or nil if unsuccessful
--- * If the code succeeded, the raw output of the code string. If the code failed, a table containing an error dictionary

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(W631) line is too long (123 > 120)

---
--- Notes:
--- * This function uses hs.osascript.applescript for execution.
--- * Use hs.osascript._osascript(source, "AppleScript") if you always want the result as a string, even when a failure occurs. However, this function can only take a string, and not a file name.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(W631) line is too long (196 > 120)

--- Returns:
--- * A boolean value indicating whether the code succeeded or not
--- * An object containing the parsed output that can be any type, or nil if unsuccessful
--- * If the code succeeded, the raw output of the code string. If the code failed, a table containing an error dictionary

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(W631) line is too long (123 > 120)

---
--- Notes:
--- * This function uses hs.osascript.javascript for execution.
--- * Use hs.osascript._osascript(source, "JavaScript") if you always want the result as a string, even when a failure occurs. However, this function can only take a string, and not a file name.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(W631) line is too long (195 > 120)

@cmsj

cmsj commented Dec 8, 2017

Copy link
Copy Markdown
Member

@rkalis please ignore the stickler-ci comments for now - we've only just enabled it and I'm still bedding it down as to what is reasonable :)

@rkalis

rkalis commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

@cmsj Aah good to know, I was confused already, as some of the new lines of documentation (like the returns) were exactly the same as some existing ones 😅😅

@cmsj cmsj closed this in ea4b56e Dec 11, 2017
@cmsj

cmsj commented Dec 11, 2017

Copy link
Copy Markdown
Member

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants