Skip to content

hs.image:colorAt() now takes into account scale - #3185

Merged
cmsj merged 1 commit into
Hammerspoon:masterfrom
latenitefilms:issue-3184-colorAt-regression
Apr 23, 2022
Merged

hs.image:colorAt() now takes into account scale#3185
cmsj merged 1 commit into
Hammerspoon:masterfrom
latenitefilms:issue-3184-colorAt-regression

Conversation

@latenitefilms

Copy link
Copy Markdown
Contributor

@latenitefilms latenitefilms changed the title hs.image:colorAt() now takes into account scale [Regression] hs.image:colorAt() now takes into account scale Apr 11, 2022

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

@cmsj

cmsj commented Apr 11, 2022

Copy link
Copy Markdown
Member

Makes sense, thanks. Does it hold up with some testing?

@latenitefilms

Copy link
Copy Markdown
Contributor Author

Yep - we’ve merged into CommandPost and it fixes some regressions we were seeing.

@github-actions

Copy link
Copy Markdown

View Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit bd9870a.

@cmsj
cmsj merged commit 4c6f32c into Hammerspoon:master Apr 23, 2022
@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Mar 12, 2023
@cmsj cmsj changed the title [Regression] hs.image:colorAt() now takes into account scale hs.image:colorAt() now takes into account scale Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-fix Pull Request implementing a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression - hs.image:colorAt() doesn't handle scale correctly

2 participants