Allow hs.chooser query to still be forwarded when no matching string exists - #3232
Merged
Conversation
…in the choices list
cmsj
requested changes
Jul 1, 2022
cmsj
left a comment
cmsj
left a comment
Member
There was a problem hiding this comment.
I like the look of this, and I also wonder if it might be worth adding the query string to the choice dictionary even when a valid choice exists? That doesn't need to be part of this PR, but we should do the LUA_NOREF/LUA_REFNIL checks before merging.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
Sorry about the commit/revert, not sure what VSCode was doing there. |
halfwit
marked this pull request as ready for review
July 1, 2022 18:55
Member
|
Thanks! Apologies for the slow merging |
cmsj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of how to implement this, it works in my local testing.
It adds a method, enableDefaultForQuery which can be passed a bool to allow the query to be returned to the final handler, even when it doesn't match an item on the choices list.