Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor icon colouring on index #22

Merged
merged 2 commits into from Oct 19, 2019

Conversation

@katiew812
Copy link
Contributor

katiew812 commented Oct 19, 2019

Refactored to use class styling vs inline

Copy link
Owner

Hammie217 left a comment

Hi Katie,

Thanks for the PR, looks like a useful code cleanup.

Could I ask you to change this from kebab-case to camelCase.

Thanks,

Copy link
Owner

Hammie217 left a comment

Looks good :)

@Hammie217 Hammie217 merged commit a50a1a7 into Hammie217:master Oct 19, 2019
@katiew812 katiew812 deleted the katiew812:icon-styling branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.