New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision HEVC file (dvhe) fails to open #1728

Open
Nomis101 opened this Issue Dec 13, 2018 · 9 comments

Comments

5 participants
@Nomis101
Copy link
Contributor

Nomis101 commented Dec 13, 2018

Description of the problem

An Ultra-HD Dolby Vision file in codec HEVC fails to open in HandBrake. I used this file:
https://4kmedia.org/lg-amaze-dolby-vision-uhd-4k-demo/

HandBrake version (e.g., 1.0.0)

20181213013227-840956d-master (2018121301)

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

macOS 10.14 Mojave

HandBrake Activity Log (see https://handbrake.fr/docs/en/latest/help/activity-log.html)

[22:55:34] macgui: Handbrake Version: 20181213013227-840956d-master  (2018121301)
[22:55:34] hb_init: starting libhb thread
[22:55:34] hb_init: starting libhb thread
[22:55:40] macgui: trying to open a folder or file
[22:55:40] macgui: ScanCore scanning titles with a duration of 10 seconds or more
[22:55:40] CPU: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
[22:55:40]  - Intel microarchitecture Skylake
[22:55:40]  - logical processor count: 8
[22:55:40] hb_scan: path=/Downloads/LG Amaze Dolby Vision UHD 4K Demo.ts, title_index=0
udfread ERROR: ECMA 167 Volume Recognition failed
disc.c:323: failed opening UDF image /Downloads/LG Amaze Dolby Vision UHD 4K Demo.ts
disc.c:424: error opening file BDMV/index.bdmv
disc.c:424: error opening file BDMV/BACKUP/index.bdmv
[22:55:40] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 6.0.0
libdvdread: Encrypted DVD support unavailable.
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[22:55:40] dvd: not a dvd - trying as a stream/file instead
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/Downloads/LG Amaze Dolby Vision UHD 4K Demo.ts':
  Metadata:
    major_brand     : mp42
    minor_version   : 1
    compatible_brands: mp42dby1isom
    creation_time   : 2017-04-13T20:09:18.000000Z
  Duration: 00:00:56.20, start: 0.000000, bitrate: 28362 kb/s
    Stream #0:0(und): Video: none (dvhe / 0x65687664), none, 3840x2160, 27713 kb/s, 60 fps, 60 tbr, 60k tbn, 60k tbc (default)
    Metadata:
      creation_time   : 2017-04-13T20:09:18.000000Z
      handler_name    : video handler
      encoder         : DOVI Coding
    Stream #0:1(und): Audio: eac3 (ec-3 / 0x332D6365), 48000 Hz, 5.1(side), fltp, 640 kb/s (default)
    Metadata:
      creation_time   : 2017-04-13T20:09:18.000000Z
      handler_name    : sound handler
    Side data:
      audio service type: main
[22:55:40] scan: decoding previews for title 1
error: No video decoder set!
[22:55:40] scan: Too few previews (0), trying harder
[22:55:40] scan: decoding previews for title 1
[22:55:40] libhb: scan thread found 0 valid title(s)
[22:55:40] macgui: ScanCore scan done
@woodstockathbf

This comment has been minimized.

Copy link

woodstockathbf commented Dec 13, 2018

As far as I know, there are no open-source Dolby Vision decoders out there, so there would be no valid source in the .ts file.

@cehoyos

This comment has been minimized.

Copy link

cehoyos commented Dec 14, 2018

https://trac.ffmpeg.org/ticket/7347
Will be fixed in a future FFmpeg version (once we can agree on the colour).

@sr55

This comment has been minimized.

Copy link
Member

sr55 commented Dec 14, 2018

Thanks Cehoyos.

@cehoyos

This comment has been minimized.

Copy link

cehoyos commented Dec 17, 2018

Jan committed the patch that was originally suggested by Igor Selivanov:
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=6ebe88f3

@bradleysepos bradleysepos added this to the 1.2.1 milestone Dec 17, 2018

@bradleysepos bradleysepos self-assigned this Dec 17, 2018

@bradleysepos

This comment has been minimized.

Copy link
Member

bradleysepos commented Dec 17, 2018

@cehoyos I take it this patch is sufficient on its own applied to release/4.1?

@cehoyos

This comment has been minimized.

Copy link

cehoyos commented Dec 17, 2018

I think so but please feel free to test with the patch linked here.
An older patch probably helps with more common Dolby Vision samples:
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=61300684

@Nomis101

This comment has been minimized.

Copy link
Contributor

Nomis101 commented Dec 17, 2018

With this patch applied, I can open the file in Handbrake (and encode it), but the color looks odd.

odd2
odd

@cehoyos

This comment has been minimized.

Copy link

cehoyos commented Dec 17, 2018

I don't think this will be improved soon (but would love to be shown wrong).

@bradleysepos

This comment has been minimized.

Copy link
Member

bradleysepos commented Dec 18, 2018

Indeed, HandBrake does not speak any form of HDR yet. So the information needed to interpret the colors properly is simply not handled. HDR and conversion to SDR are on the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment