New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use an alternative decimal separator per locale for localization #1730

Open
Nomis101 opened this Issue Dec 15, 2018 · 0 comments

Comments

2 participants
@Nomis101
Copy link
Contributor

Nomis101 commented Dec 15, 2018

Description of the problem

For the HandBrake GUI in English language a point is used as the decimal separator. For localization purpose a comma (or momayyez) might be needed depending on the locale. For example in

Pass 1 of 1, 88.41 % (253.24 fps, avg 255.46 fps, ETA 00h00m06s)

the decimal separator is currently fixed to the en-US point. It would be nice to allow the localizer to use the appropriate separator for the given language.

For Win I found this:
https://docs.microsoft.com/en-us/dotnet/api/system.globalization.numberformatinfo.numberdecimalseparator?view=netframework-4.7.2

For Mac I found this:
https://developer.apple.com/documentation/foundation/nslocale/1643064-decimalseparator

HandBrake version (e.g., 1.0.0)

Current master

@sr55 sr55 added the Enhancement label Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment