New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacGui: Fix clipping text in localized HBPictureHUDController.xib #1759

Open
Nomis101 opened this Issue Dec 27, 2018 · 0 comments

Comments

3 participants
@Nomis101
Copy link
Contributor

Nomis101 commented Dec 27, 2018

Description of the problem

There is a clipping text in the localized HBPictureHUDController.xib in the "Scale to screen" button. I was wondering why, because this xib is already set to auto layout. Than I found, that the auto layout needs more space to enlarge the button, so I increased the size of the whole HUD. This fixed the issue. So I made a patch:
Nomis101@796824c

Could you please check if this is fine with you, so I can make a pull request out of this patch? Just increasing the size of the HUD changed quite a lot of lines...

HandBrake version (e.g., 1.0.0)

1.2.0

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

macOS 10.14 Mojave

Error message text or screenshot

Clipping text:
clipping-text

@sr55 sr55 added the Bug label Dec 30, 2018

@sr55 sr55 added this to the 1.2.1 milestone Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment