New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload default preset for every source added #1779

Open
wellloaded opened this Issue Jan 2, 2019 · 6 comments

Comments

2 participants
@wellloaded
Copy link

wellloaded commented Jan 2, 2019

It would be nice to have a user selectable option in the Handbrake preferences to forcedly reload the default preset for every new source added (either via open or drag and drop).

At the moment the settings for one video are passed through the next source. This might or might not be wanted, hence the request.

@sr55

This comment has been minimized.

Copy link
Member

sr55 commented Jan 2, 2019

What operating system are you on?

@wellloaded

This comment has been minimized.

Copy link

wellloaded commented Jan 2, 2019

Windows 10

@sr55

This comment has been minimized.

Copy link
Member

sr55 commented Jan 2, 2019

What is it your changing that differs from preset.

Currently:
Dimensions, Audio, Subtitles, Chapters all have to reload as they are source dependant so do so already.
Filters, Video, don't as they are not related to the source.

@wellloaded

This comment has been minimized.

Copy link

wellloaded commented Jan 2, 2019

Ok an example is the video quality. Say default is 28 for me but one source only I move it to 24 for whatever reason, the very next file I drop on Handbrake will still get 24 unless I manually reload the preset via "Reload" click or manually move it to 28. Same thing if I set the greyscale filter. This happened to me multiple times I have a black and white input I set the greyscale to optimise the output size but forget to unset for the next video which gets converted in greyscale :-(

I read what you wrote about video and filter... but why does it have to be related to the source if I can ask? My preset is there for a reason, it's there because 90% of the video I process are good with the preset. So it's a safaguard for the handbrake user to blindly assume all the parametes are set to the default because that's the starting point wanted. If we have to go and recheck all the parameters because something is resetted to the preset and something else not it probably defeats the concept. Beside this if I manually click "Reload" it will indeed affect filters and video so why shouldn't a drag and drop do the same?

My opinion of course.

@sr55 sr55 added the Enhancement label Jan 3, 2019

@sr55

This comment has been minimized.

Copy link
Member

sr55 commented Jan 3, 2019

Fair enough. Marked as an enhancement and we can look into it at some point when we have time :)

@wellloaded

This comment has been minimized.

Copy link

wellloaded commented Jan 3, 2019

thanks for listening to the users 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment