Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fribidi-1.0.5.tar.gz without symlinks inside #2014

Open
maximd33 opened this issue Mar 29, 2019 · 4 comments

Comments

3 participants
@maximd33
Copy link
Contributor

commented Mar 29, 2019

Description of the problem

it would be good to keep contribs as archives without symbolic links inside.

MSYS2/ tar extract cannot handle properly creation of symbolic links on Windows OS:
/usr/bin/mkdir -p contrib/fribidi/ sha256 (../download/fribidi-1.0.5.tar.gz) = aee3a93d081c293eaca9157700f17dc780a0b6674bc911decc5aaa43aec9abd7 (pass) /usr/bin/rm -fr ./contrib/fribidi/fribidi-1.0.5/ /usr/bin/tar xfC ../download/fribidi-1.0.5.tar.gz ./contrib/fribidi/ /usr/bin/tar: fribidi-1.0.5/README: Cannot create symlink to ‘README.md’: No such file or directory /usr/bin/tar: Exiting with failure status due to previous errors make: *** [../contrib/fribidi/module.rules:2: contrib/fribidi/.stamp.fribidi.extract] Error 2

HandBrake version (e.g., 1.0.0)

Please replace this text with the version of HandBrake you are running.

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

Please replace this text with the version of the operation system you are running.

Error message text or screenshot

Please provide any error messages or screenshots that may help.

HandBrake Activity Log (see https://handbrake.fr/docs/en/latest/help/activity-log.html)

Please replace this text with the Activity log, or upload the log file to Github by dropping the file on this post.
Leave the ~ marks above and below.
@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@sr55 I'm thinking we host a fixed tarball without the symlink and report the issue upstream to fribidi. Thoughts?

@sr55

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

My preference would be to have identical tars on primary and secondary and wait for upstream to fix in the next release. I.e. there would be no ambiguity and if our servers not available builds still work.

I generally don't recommend msys on windows, especially now we have the Ubuntu shell via Windows 10 WSL and the app store.

@sr55 sr55 added the Upstream Issue label Apr 3, 2019

@maximd33

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

sr55, no issue for you with WSL?

upstream is https://github.com/fribidi/fribidi ?

@sr55

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

I've been using WSL for some time now and it builds / works fine there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.