Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handbrake 1.2.2 - Recognize/respect default and forced SRT subtitle on file open #2107

Open
pitcher12 opened this issue May 16, 2019 · 6 comments

Comments

3 participants
@pitcher12
Copy link

commented May 16, 2019

Handbrake 1.2.2 - Windows 7 / 10

Opening MKV file, Handbrake ignores/disregards default flag/setting for SRT [UTF-8] subtitle upon file open

Please fix so that Handbrake recognizes and respects default (i.e. checkbox for default is automatically checked) upon file open if default was set in original file

@pitcher12 pitcher12 changed the title Handbrake 1.2.2 - Recnogize/respect default SRT subtitle on file ope Handbrake 1.2.2 - Recognize/respect default SRT subtitle on file open May 16, 2019

@pitcher12 pitcher12 changed the title Handbrake 1.2.2 - Recognize/respect default SRT subtitle on file open Handbrake 1.2.2 - Recognize/respect default and forced SRT subtitle on file open May 16, 2019

@woodstockathbf

This comment has been minimized.

Copy link

commented May 16, 2019

A separate SRT or SSA file does not have a "default" flag to recognize. It also does not have "forced" flags within it. Unless the subtitle is already multiplexed into the source file, there isn't a way to set a behavior for selecting it.

Adding a separate SRT or SSA file is a manual procedure, checking the "default" box while entering its name really that difficult.

@sr55

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

I think he's referring to embedded. Even in that situation, it's not something I'd want to be default behaviour. Would need to be an off by default configuration under the subtitle defaults.

@sr55 sr55 added the Enhancement label May 16, 2019

@pitcher12

This comment has been minimized.

Copy link
Author

commented May 16, 2019

I think part of the issue from what I am reading above and partially mentioned in #2102 could be a misunderstanding about how "default" is being implemented/interpreted by different pieces of software and/or hardware.

Embedded is probably the best and closest definition of what I am looking for.

So effectively the request is:

If the subtitle was indeed multiplexed into the source file and set as default and forced, then this same behavior should be respected by Handbrake when opening the file and the default checkbox ticked (so 'default' is automatically checked without user intervention).

Likewise, if default is not set to yes in the original file, when Handbrake opens the file, the default box should not be checked.

And of course even if the original file did have default a yes and Handbrake respected this, a user could still manually override this behavior if they wish (i.e. untick the check box).

Adding a separate SRT or SSA file is a manual procedure, checking the "default" box while entering its name really that difficult.

Yes it can become a very time consuming task when trying to do so across 50+ files or more.

@sr55

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

All you achieve by this, is moving your own problem onto a different set of users. Many people do NOT want this to be the default behaviour. As i said, this behaviour could be a preference but it's not something that would be set as default.

@woodstockathbf

This comment has been minimized.

Copy link

commented May 16, 2019

If you are doing this on multiple files, it might be simpler to use the command line interface, as a batch job. The assumption would be that the SRT or SSA file would be in the same directory and have the same name (other than extension) as the source file. This is relatively easy to script for all three major platforms that handbrake runs on.

@pitcher12

This comment has been minimized.

Copy link
Author

commented May 16, 2019

If this behavior can even be a preference (that can be toggled in the options as enabled/disabled for example) at least that is something.

Many people do NOT want this to be the default behaviour.

I am a little unsure why other users would not want this behavior as standard (it seems to be the obvious route), but maybe there is something I am missing.

I am wondering if again it is the misunderstanding by how "default" operates and/or how it is supposed to work. I don't actually know for sure, but my experience is that when the user switches on subtitles on their device, the default subtitle is the subtitle track that is gone to instantly, whether that is Track 1 or Track 5 in the list of subtitles. I have not found it to mean that the subtitle turns on by default. That is what Forced does for me.

If you are doing this on multiple files, it might be simpler to use the command line interface, as a batch job. The assumption would be that the SRT or SSA file would be in the same directory and have the same name (other than extension) as the source file.

I think you are misunderstanding something above, I am only referring to files that already have the SRT multiplexed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.