Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sound when the queue completes #2130

Open
yehocetel opened this issue Jun 4, 2019 · 6 comments

Comments

2 participants
@yehocetel
Copy link

commented Jun 4, 2019

Description of the problem

In Preferences->General->When Done there are two options: 1. Play a sound when each encode completes and 2. Play a sound when the queue completes.
There is a browse button, so i added a 2 second sound effect. But it doesn't work. No sound. Does it have to be a special format? Am i the only one who has the problem?

HandBrake version (e.g., 1.0.0)

1.2.2

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

W10

Error message text or screenshot

Ticket-machine-sound.zip

HandBrake Activity Log (see https://handbrake.fr/docs/en/latest/help/activity-log.html)

Please replace this text with the Activity log, or upload the log file to Github by dropping the file on this post.
Leave the ~ marks above and below.

@yehocetel yehocetel changed the title When Done->Play a sound when the queue completes No sound when the queue completes Jun 4, 2019

@sr55 sr55 added the Bug label Jun 6, 2019

@sr55 sr55 added this to the 1.3.0 milestone Jun 6, 2019

@sr55 sr55 self-assigned this Jun 6, 2019

@sr55 sr55 removed the Bug label Jun 6, 2019

@sr55 sr55 removed this from the 1.3.0 milestone Jun 6, 2019

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

The file you provided seems to play fine for either encode / queue actions are complete.

I assume you defiantly have one of the 2 checkboxes ticked?
Does it playback fine in Windows Media Player and Groove Music?

@yehocetel

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

The file you provided seems to play fine for either encode / queue actions are complete.

I assume you defiantly have one of the 2 checkboxes ticked?
Does it playback fine in Windows Media Player and Groove Music?

I only want to use it for the queue completion.
Yes it plays fine, no problems. But i noticed something. In the Volume Mixer from Windows, there is no Handbrake. Is that normal?

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

image

It will only show up after it's played the sound file atleast once. If after the queue completes it's now showing up, then it failed to play the file for some reason. Unfortunately if it's not throwing any kind of error, there isn't any way for me to know why this might be happening.

@yehocetel

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

image

It will only show up after it's played the sound file atleast once. If after the queue completes it's now showing up, then it failed to play the file for some reason. Unfortunately if it's not throwing any kind of error, there isn't any way for me to know why this might be happening.

Maybe if next to the 'browse' button there was a 'play' button to test the audio it would work. Then again i don't know what you did so that Handbrake appeared in your volume mixer.

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Just ran an encode. After the first time it plays the file, it shows up.
Test button isn't a bad idea!

sr55 added a commit that referenced this issue Jun 6, 2019

WinGui: Add a "Test" button to the When Done Audio options. Also log …
…the "MediaFailed" event to the log otherwise we get silent failures. #2130
@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Just checking in to see if the "play" button in the nightly does anything for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.