Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Options remain modifiable after selecting Auto Passthru #2135
Description of the problem
When selecting Auto Passthru as the codec in the audio track Selection Behavior pane, the options to the right remain modifiable. However, when selecting a Passthru option for the codec in the Audio tab itself, those same options are greyed out.
This occurs if accessing the pane via either the Audio tab --> Selection Behavior button or the Save New Preset --> Audio --> Selection Behavior button.
HandBrake version (e.g., 1.0.0)
Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)
macOS High Sierra 10.13.6
Error message text or screenshot
I don't think that's accurate --- Please review the screenshots I included. For example, I can set the fallback encoder to "None" and those options remain modifiable.
I would agree with you if the codec was set to the same value as the fallback encoder but of course, that's not what I have shown and in any event, there is no option for "Auto Passthru" as the fall back encoder.
If what you're saying is that those options are used for the fallback encoder regardless of the actual codec setting, then the UI should be modified to indicate which codec the different settings relate.
Fallback encoder is the fallback encoder used by "Auto Passthru". The settings for "Auto Passthru" are always for the encoder selected in "Passthru Fallback".
The settings are disabled in the main window when you select a passhtru option because HandBrake knows already if the track can be passhtru or not. But in the Selection Behavior there is no way to know on which audio track the settings will be applied.
Yes, they should be disabled if the "Passthru Fallback" is set to None, but everything else works as intended.
Am I the only one who thinks the GUI could better state that those settings pertain to the fallback encoder rather than the codec being selected? Nearly the exact same setup exists in the Audio tab yet those settings do pertain to the selected codec. I'm glad to help out and make the tweaks - let me know if that is acceptible.
Fixed the options state in 72b57de.
@sr55 the encoder options should be disabled only when the fallback encoder is none and auto passthru is selected, the other passhtru options ("ac3 passhtru" for example) will fallback to the encoder in the option name ("ac3 passthru" to ac3, "aac passthru" to aac).