Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options remain modifiable after selecting Auto Passthru #2135

Open
cyb3rz3us opened this issue Jun 5, 2019 · 8 comments

Comments

4 participants
@cyb3rz3us
Copy link

commented Jun 5, 2019

Description of the problem

When selecting Auto Passthru as the codec in the audio track Selection Behavior pane, the options to the right remain modifiable. However, when selecting a Passthru option for the codec in the Audio tab itself, those same options are greyed out.

This occurs if accessing the pane via either the Audio tab --> Selection Behavior button or the Save New Preset --> Audio --> Selection Behavior button.

HandBrake version (e.g., 1.0.0)

1.2.2

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

macOS High Sierra 10.13.6

Error message text or screenshot

Modifiable options found in the Selection Behavior pane
hb_autopass_noGrey

Greyed out version found in the Audio tab
hb_autopass_greyedOut

@jstebbins

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Auto-passthrough has an associated "Passthru Fallback" encoder. When it is not possible to passthrough the audio, the fallback encoder is used. The options you are referring to are used in this scenario.

@cyb3rz3us

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

I don't think that's accurate --- Please review the screenshots I included. For example, I can set the fallback encoder to "None" and those options remain modifiable.

I would agree with you if the codec was set to the same value as the fallback encoder but of course, that's not what I have shown and in any event, there is no option for "Auto Passthru" as the fall back encoder.

If what you're saying is that those options are used for the fallback encoder regardless of the actual codec setting, then the UI should be modified to indicate which codec the different settings relate.

@galad87

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Fallback encoder is the fallback encoder used by "Auto Passthru". The settings for "Auto Passthru" are always for the encoder selected in "Passthru Fallback".

The settings are disabled in the main window when you select a passhtru option because HandBrake knows already if the track can be passhtru or not. But in the Selection Behavior there is no way to know on which audio track the settings will be applied.

Yes, they should be disabled if the "Passthru Fallback" is set to None, but everything else works as intended.

sr55 added a commit that referenced this issue Jun 6, 2019

WinGui: Don't show encoder options when Fallback = None and a passthr…
…u encoder is selected on the Audio Defaults screen. Also add the ? as the MacGui has. #2135

@sr55 sr55 self-assigned this Jun 6, 2019

@sr55 sr55 added this to the 1.3.0 milestone Jun 6, 2019

@sr55 sr55 added the Bug label Jun 6, 2019

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Ditto on @galad87 's comments

I've corrected this in the WinGui so it won't show the encoder option for a fallback encoder = none and a pasthru codec option selected.

@cyb3rz3us

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

Am I the only one who thinks the GUI could better state that those settings pertain to the fallback encoder rather than the codec being selected? Nearly the exact same setup exists in the Audio tab yet those settings do pertain to the selected codec. I'm glad to help out and make the tweaks - let me know if that is acceptible.

@galad87

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Fixed the options state in 72b57de.

@sr55 the encoder options should be disabled only when the fallback encoder is none and auto passthru is selected, the other passhtru options ("ac3 passhtru" for example) will fallback to the encoder in the option name ("ac3 passthru" to ac3, "aac passthru" to aac).

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Looks like the JSON API doesn't behave like that.
"track 1: incompatible encoder 'none' for muxer 'av_mp4'"
@jstebbins thoughts?

@jstebbins

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

It's a sanity check in hb_dict_to_job. It currently fails. It should probably just drop the track and produce a log message if the audio codec is not "none". I'll throw together a quick PR for you to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.