Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preset option missing in macOS version #2137

Open
cyb3rz3us opened this issue Jun 6, 2019 · 6 comments

Comments

3 participants
@cyb3rz3us
Copy link

commented Jun 6, 2019

Description of the problem

UPDATE: The screenshots posted initially were incorrect. Apologies for any confusion I may have induced.

ISSUE: After modifying a user-defined preset, there is no option to update the preset and save the modifications.

HandBrake version (e.g., 1.0.0)

1.2.2

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

macOS 10.13.6 High Sierra

Error message text or screenshot

preset audio "Selection Behavior" pane - this is the initial condition
hb_preset-initial

"Preset" dropdown menu after modification - no update option exists
hb_preset-dropdown_postMod

@cyb3rz3us

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

I think the issue is just wording in the Preset the dropdown menu. If I save the changes in the audio Selection Behavior pane and then select Presets --> Make Default Preset, then it appears the mods to the preset are saved.

If this is desired behavior, then should this menu item be changed to be close to parity with the Windows version --- for example, to read "Update selected preset"?

@galad87

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

No, "Make Default Preset" doesn't update the presets.

@cyb3rz3us

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

Please ignore my earlier comment if you already read it. I re-tested this morning and the Presets --> Make Default Preset command is not saving as I believed it did yesterday. So I likely had a bad test.

I will report back on this aspect if and when I have reliable data but in any event, the update preset is still missing.

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Yes, it's not available on the mac version currently.

@cyb3rz3us

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

@sr55: Understood - Thanks. Should I make this an FR then? I did search first and did not find anything relating to this. Also, am I free to pull the code and modify for my own purposes?

@sr55

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

You can alter the source code to your hearts content. You can also raise a pull request too if you want to contribute back.

@sr55 sr55 added the Enhancement label Jun 11, 2019

@sr55 sr55 added this to the Unscheduled milestone Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.