Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last SRT subtitlte not burnt in if caption end time is beyond video end time #2147

Open
cmcgerty opened this issue Jun 16, 2019 · 1 comment

Comments

3 participants
@cmcgerty
Copy link

commented Jun 16, 2019

Description of the problem

If the end time of the final caption in an SRT file is beyond the end time of the video clip then it is not burnt in. This is very common if the SRT file is generated by YouTube. In the YouTube viewer, this caption is displayed and remains on screen at the end of the clip. In Handbrake the last caption is not displayed on the burnt in file.

HandBrake version (e.g., 1.0.0)

1.2.2 (2019022300)

Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)

Windows 10 (1903)

@jstebbins

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

This may be fixed by f87655e
The commit message only mentions initial subtitle, but I also modified the logic for the last subtitle.

@sr55 sr55 added the Bug label Jul 11, 2019

@sr55 sr55 added this to the 1.3.0 milestone Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.