Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Large Subtitle offsets cause hard crash. #2161
While transcoding episodes of a TV show where 4 episodes were in 1 file, I had the chapters set to 19-24 for the fourth episode on the disk.
In order to get the subtitles to line up in the preview encode (going back, even the episodes I got to line up in preview didn't encode lined up correctly, maybe another bug?), I was having to set the offset to -581000ms. When I tried to start the normal encode, Handbrake would allocate memory until it was using all my system's free RAM (~45GB) then would have an allocation error and Windows would force close Handbrake.
Tried using different subtitle files for the specific episode and eventually found that if I set the offset to 0 there weren't any problems, so I assume the large offset is what caused the crash.
My workaround was to encode the episodes to their own files first and then do a second encode to get the subtitles in without an offset.
I still can't reproduce using x264 demo iso. I see no memory usage spike on linux and valgrind shows nothing unusual :-\
My srt file is a short sample: