Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix some more warnings (a question) #2265
Description of the problem
I would like to fix some more warnings I see while building HandBrake. Currently the easy to fix ones. But I would have some questions.
The first warning I would like to fix is
You see this warning if Opus is build in debug mode, see https://bugs.chromium.org/p/chromium/issues/detail?id=355440
The second warning I would like to fix and I have a question, is:
This warning comes from this line:
HandBrake version (e.g., 1.0.0)
Operating system and version (e.g., Ubuntu 18.04 LTS, macOS 10.14 Mojave, Windows 10 1809)
macOS 10.14 Mojave
It would be helpful if you could figure out building which contribs causes this warning. I suspect they are using something else, and we should avoid passing this if possible.
Optimizations are clearly enabled. AVX will be disabled on this CPU at run time since it's not available. This appears to be correct.
Since there is no inline assembly in libopus for platforms other than arm, I'm guessing
Reopening pending further investigation regarding contribs affected by
Aside, @Nomis101, if you'd like to test cross building for Windows, you can do this within macOS. See