Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no default filters #2301

Closed
maximd33 opened this issue Sep 9, 2019 · 1 comment

Comments

@maximd33
Copy link
Contributor

commented Sep 9, 2019

any objections to do not insert, currently permanently used, filters unless needed ?

such as:
HB_FILTER_VFR

hb_add_filter2(filter_list, filter_dict);

HB_FILTER_CROP_SCALE

hb_add_filter2(filter_list, filter_dict);

@jstebbins

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

VFR does 2 main things

  • If the detelecine filter is enabled and the source is hard telecined, vfr smooths out timestamp irregularities caused by detelecine frame drops.
  • If the user has selected constant or peak framerate, it enforces the setting by dropping or duplicating frames.

So this filter should not be disabled if detelecine, cfr, or pfr is enabled.

Crop/scale should only be disabled if there is no cropping or scaling (or if it can be replaced by a qsv alternative).

@sr55 sr55 closed this Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.