Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinGUI Nightly 20210511210419-edb7bbe94-master - Dimensions Tab: Maintain Aspect Ratio Broken (Bad Math) #3593

Closed
Synapto opened this issue May 16, 2021 · 2 comments
Assignees
Labels

Comments

@Synapto
Copy link

Synapto commented May 16, 2021

Problem description:

I'm referring to the functionality of the Keep Aspect Ratio toggle checkbox, renamed to "Automatic" in the latest nightlies.

  1. "Display Size: 0, Aspect Ratio: 1:INFINITY"
    Doing nothing except clearing the "Automatic" checkbox under "Final Dimensions:" produces a Display Size of 0 and a correspondingly calculated Aspect Ratio of Infinity.

  2. "32" Everywhere
    Doing nothing except selecting Anamorphic: None or Custom, then clearing the "Automatic" checkbox produces a Scaled Size: height of 32. If you then clear the "Optimal Size:" checkbox, you can modify that obviously borked height value and watch the width value instantly bork itself to 32 as well.

HandBrake version (e.g., 1.3.0):

WinGUI x86_64 Nightly 20210511210419-edb7bbe94-master (2021051201)
https://handbrake.fr/nightly/HandBrake-20210512-edb7bbe94-x86_64-Win_GUI.zip

Operating system and version (e.g., Ubuntu 19.10, macOS 10.15 Catalina, Windows 10 1909):

Edition Windows 10 Pro
Version 20H2
Installed on ‎26/‎08/‎20
OS build 19042.985
Experience Windows Feature Experience Pack 120.2212.2020.0

Error message text and/or screenshot:

Fresh portable install with any file loaded:
image

Infinity
image

32 Height
image

32 Everywhere
image

HandBrake Activity Log:

All of these GUI bugs can be effortlessly reproduced using a portable install of the latest snapshot build, and changing NO SETTINGS OR OPTIONS FROM THE DEFAULT other than the ones I've indicated.

HandBrake Nightly 20210511210419-edb7bbe94-master (2021051201)
OS: Microsoft Windows NT 10.0.19042.0
CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
Ram: 31622 MB, 
GPU Information:
  Intel(R) UHD Graphics 630 - 27.20.100.9316
Screen: 1920x1080
Temp Dir: D:\WinTemp\HandBrake\tmp\
Install Dir: D:\WinTemp\HandBrake\
Data Dir: D:\WinTemp\HandBrake\storage\HandBrake\Nightly

-------------------------------------------

[10:08:01] hb_init: starting libhb thread

 # Starting Scan ...

[10:08:01] CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
[10:08:01]  - Intel microarchitecture Kaby Lake
[10:08:01]  - logical processor count: 8
[10:08:01] Intel Quick Sync Video support: yes, gpu list: 0
[10:08:01] Intel Quick Sync Video integrated adapter with index 0
[10:08:01]  - Intel Media SDK hardware: API 1.34 (minimum: 1.3)
[10:08:01]  - Decode support:  h264 hevc (8bit: yes, 10bit: yes)
[10:08:01]  - H.264 encoder: yes
[10:08:01]     - preferred implementation: hardware (1) via D3D11
[10:08:01]     - capabilities (hardware):  breftype icq+la+i+downs vsinfo opt1 opt2+mbbrc+extbrc+trellis+ib_adapt+nmpslice
[10:08:01]  - H.265 encoder: yes (8bit: yes, 10bit: yes)
[10:08:01]     - preferred implementation: hardware (1) via D3D11
[10:08:01]     - capabilities (hardware):  bpyramid icq vsinfo opt1
[10:08:01] hb_scan: path=D:\x265\!SOURCE_1080p_Tractor.y4m, title_index=0
udfread ERROR: ECMA 167 Volume Recognition failed
src/libbluray/disc/disc.c:333: failed opening UDF image D:\x265\!SOURCE_1080p_Tractor.y4m
src/libbluray/disc/disc.c:437: error opening file BDMV\index.bdmv
src/libbluray/disc/disc.c:437: error opening file BDMV\BACKUP\index.bdmv
src/libbluray/bluray.c:2646: nav_get_title_list(D:\x265\!SOURCE_1080p_Tractor.y4m\) failed
[10:08:01] bd: not a bd - trying as a stream/file instead
libdvdread: DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdnav: vm: vm: failed to read VIDEO_TS.IFO
[10:08:01] dvd: not a dvd - trying as a stream/file instead
Input #0, yuv4mpegpipe, from 'D:\x265\!SOURCE_1080p_Tractor.y4m':
  Duration: 00:00:27.60, start: 0.000000, bitrate: 622081 kb/s
    Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p(progressive), 1920x1080, SAR 1:1 DAR 16:9, 25 fps, 25 tbr, 25 tbn, 25 tbc
[10:08:01] scan: decoding previews for title 1
[10:08:01] scan: 10 previews, 1920x1080, 25.000 fps, autocrop = 0/0/0/0, aspect 16:9, PAR 1:1, color profile: 1-1-1
[10:08:01] libhb: scan thread found 1 valid title(s)

 # Processing Scan Information ...


 # Scan Finished ...

[10:08:02] decomb: deinterlaced 1 | blended 0 | unfiltered 0 | total 1
@sr55 sr55 added the Bug label May 16, 2021
@sr55 sr55 self-assigned this May 16, 2021
sr55 added a commit that referenced this issue May 16, 2021
@sr55 sr55 closed this as completed May 30, 2021
@passat1
Copy link

passat1 commented Jun 1, 2021

In version "20210528-29b73dcaa" issue with "Anamorphic" set to "None" and "Final Dimensions - Automatic" set "off" and "Scaled Size" value forcing values "32/34" is not solved.
There is no way to manually set final picture dimensions with "Anamorphic" set to "None" (PAR 1:1), which is best when resizing.

@sr55 sr55 reopened this Jun 1, 2021
@sr55
Copy link
Contributor

sr55 commented Jun 1, 2021

Should be now.

@sr55 sr55 closed this as completed Jun 1, 2021
sr55 added a commit that referenced this issue Jun 1, 2021
…nging width or Height. (Prevents the case where you resolutions override your actions). Noting that Display Width can be changed to create non-ar defined content. #3593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants