Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save New Preset: saves duplicate #4804

Closed
Andrew-RH opened this issue Jan 5, 2023 · 5 comments
Closed

Save New Preset: saves duplicate #4804

Andrew-RH opened this issue Jan 5, 2023 · 5 comments
Labels
Milestone

Comments

@Andrew-RH
Copy link

Problem Description

Click the 'Save New Preset' button.
Enter a name for the new preset.
Select from menu: Presets->Manage Presets
The name is shown twice under 'Custom Presets'
(workaround is to select one of the presets and delete it)

Activity Log, Crash Log or any other details

HandBrake 1.6.0 (2022122800)
OS: Microsoft Windows NT 10.0.22621.0
CPU: AMD Ryzen 5 5600X 6-Core Processor             
Ram: 32683 MB, 
GPU Information:
  NVIDIA GeForce GTX 750 Ti - 31.0.15.2686
Screen: 2560x1080
Temp Dir: C:\Users\andre\AppData\Local\Temp\
Install Dir: C:\Program Files\HandBrake\
Data Dir: C:\Users\andre\AppData\Roaming\HandBrake

What Operating System are you running?

Windows 11 Pro 22621.963

What version of HandBrake are you running?

1.6.0 (2022122800)

Where did you download HandBrake from?

https://handbrake.fr/rotation.php?file=HandBrake-1.6.0-x86_64-Win_GUI.exe

@sr55
Copy link
Contributor

sr55 commented Jan 5, 2023

I can't reproduce this.

Any chance you can step by step screenshot what your doing. It actively blocks saving a preset with the same name.

@Andrew-RH
Copy link
Author

Attached zip file containing screenshots of sequence to reproduce :
Handbrake Presets Issue - Screenshots 2023-01-05.zip

@sr55 sr55 added Bug and removed Awaiting Feedback labels Jan 6, 2023
@sr55 sr55 added this to the 1.6.1 milestone Jan 6, 2023
@sr55
Copy link
Contributor

sr55 commented Jan 6, 2023

Thanks. Managed to reproduce it now.

@sr55 sr55 closed this as completed in 3e9974c Jan 6, 2023
sr55 added a commit that referenced this issue Jan 6, 2023
…erwriting previously added presets. Fixes #4804

(cherry picked from commit 2ea063b4849c171459f407d94034a20ee511ae23)
@sr55
Copy link
Contributor

sr55 commented Jan 6, 2023

That should be it fixed. Thanks for the port.

The next snapshot build will include the fix, or 1.6.1 will probably not be so far in the future
https://github.com/HandBrake/HandBrake-snapshots

@Andrew-RH
Copy link
Author

Andrew-RH commented Jan 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants