Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for VideoToolbox hardware encoding. #1522
referenced this pull request
Aug 7, 2018
This does not work on my Mac Pro. I have both NVidia GTX 670 and GT 640 cards installed (both support Metal and Mojave, if that matters). Additionally, while I see the H.265 encoder, I do not see the H.264 variant.
Default preset, H.265 (VideoToolbox) encoder, ABR mode, 6000 kbps. Same for one or two pass.
I agree with this, better to disable the quality mode controls.
A separate slider control with bit rate stops might be a good option; e.g., the bit rate field could be converted to a stepper that adjusts in 5 kbps increments, and the slider could adjust in 100 kbps increments while updating the stepped field.