Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PS4 Pro profile #2099

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@e-minguez
Copy link

commented May 13, 2019

Before Posting:

Description of Change:
As a PS4 Pro user, I would like to be able to encode 4K videos easily using handbrake to watch them on my PS4 Pro.

Test on:

  • Windows 10+ (via MinGW)
  • macOS 10.13+
  • Ubuntu Linux
  • Fedora Linux

Screenshots (If relevant):
n/a

Log file output (If relevant):
n/a

@bradleysepos bradleysepos self-assigned this May 13, 2019

@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

The commit might have an indentation or line endings issue. Looks like the entire file has changed, not just your additions.

@e-minguez e-minguez force-pushed the e-minguez:pr4pro_preset branch from 188e35c to ff4e23f May 13, 2019

@e-minguez

This comment has been minimized.

Copy link
Author

commented May 13, 2019

The commit might have an indentation or line endings issue. Looks like the entire file has changed, not just your additions.

I'm sorry, I believe I've fixed it now.

@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

I'm sorry, I believe I've fixed it now.

Thanks, I'll take a look shortly. 😸

@bradleysepos bradleysepos force-pushed the e-minguez:pr4pro_preset branch from ff4e23f to 0ca5537 May 13, 2019

@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

I pushed a revision with some fixes for formatting and such. Please test and let us know if everything is working, then I'll merge. Thanks!

@bradleysepos bradleysepos force-pushed the e-minguez:pr4pro_preset branch from 0ca5537 to be7a94f May 13, 2019

@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Helps to git add .... Fixed.

@e-minguez

This comment has been minimized.

Copy link
Author

commented May 14, 2019

I need to test it, but LGTM.

@bradleysepos

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.