Added linux support for amf encoder through vulkan. #2151

OvchinnikovDmitrii · 2019-06-18T13:04:08Z

Description of Change:
Added linux support for amf encoder through vulkan.

To use h.264(AMD VCE) encoder on linux amdgru-pro version 19.20+ and amf-amdgpu-pro package(amdgru-pro contains, but does not install automatically) are required.(https://www.amd.com/ru/support/)

initialization of amf encoder occurs in this order:

trying to initialize through dx11
trying to initialize through dx9
trying to initialize through vulkan

Only vulkan initialization available on linux.

Test on:

[+ ] Windows 10+ (via MinGW)
[ +] Ubuntu Linux

jstebbins · 2019-06-18T14:45:31Z

The changes to libhb look innocent enough. I can't test since I don't have the necessary hardware.

Have you submitted the ffmpeg patch to ffmpeg yet? I don't see it on their mailing list. It would be nice to have that reviewed and accepted by them before committing to HandBrake.

OvchinnikovDmitrii · 2019-06-18T14:52:58Z

The changes to libhb look innocent enough. I can't test since I don't have the necessary hardware.

Have you submitted the ffmpeg patch to ffmpeg yet? I don't see it on their mailing list. It would be nice to have that reviewed and accepted by them before committing to HandBrake.

Not yet, but I will.
It takes time to review and accept.

jstebbins · 2019-06-18T14:59:27Z

It takes time to review and accept.

Been there, done that 😜

sr55 · 2019-07-12T20:19:58Z

Ditto on hardware :/

bradleysepos · 2019-08-05T10:03:02Z

@OvchinnikovDmitrii Will you please re-post the ffmpeg-devel thread here so we can more easily follow it? Thanks.

OvchinnikovDmitrii · 2019-08-08T18:51:11Z

Hi! i reuploaded a new version of a patch (with docs and some refactoring) (https://patchwork.ffmpeg.org/patch/14319/).

OvchinnikovDmitrii · 2019-08-28T06:41:51Z

Hi! FFmpeg accepted the patch (FFmpeg/FFmpeg@f8ad2dd)

bradleysepos · 2019-08-28T16:05:40Z

Awesome. I requested a review on #ffmpeg-devel IRC yesterday and Philip came through.

@jstebbins Are you good with this going in HandBrake?

jstebbins · 2019-08-28T16:58:57Z

Yep, fine by me 👍

bradleysepos · 2019-08-28T17:12:07Z

Merged. Thanks @OvchinnikovDmitrii!

sr55 · 2019-09-03T18:58:07Z

@OvchinnikovDmitrii We have a user reporting that it's not currently working on a Radeon VII with amdgpu pro driver.

0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-03 19:45:37 23BD27C0 [AMFContextImpl] Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
[19:45:37] VCE: AMF failed to initialise on the given Vulkan device.
Cannot load libnvidia-encode.so.1
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-03 19:45:37 23BD27C0 [AMFContextImpl] Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-03 19:45:37 23BD27C0 [AMFContextImpl] Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-03 19:45:37 23BD27C0 [AMFDeviceVulkanImpl] Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-03 19:45:37 23BD27C0 [AMFContextImpl] Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
[19:45:37] hb_init: starting libhb thread
[19:45:37] thread 7fef1a9b7700 started ("libhb")

-7 appears to be VK_ERROR_DEVICE_LOST which doesn't really tell us much.

OvchinnikovDmitrii · 2019-09-04T08:08:48Z

@sr55
Could you provide some more info?

Driver version
Was amf-amdgpu-pro package installed?
Does vulkan works normally?(simplest way to check "vulkaninfo | less", vulkaninfo can be installed by "sudo apt-get install vulkan-utils")

sr55 · 2019-09-04T16:53:15Z

Let me confirm.

He did say that the ffmpeg build works fine so it would suggest the vce_common.c init is the failure point

"VCE: AMF failed to initialise on the given Vulkan device."
That seems to be hitting AMF library directly.

sr55 · 2019-09-06T18:43:43Z

s55: amf version is 19.30_855429-1, output of vulkaninfo: https://pastebin.com/J0udhGX8

That's the report back

OvchinnikovDmitrii · 2019-09-09T15:34:03Z

s55: amf version is 19.30_855429-1, output of vulkaninfo: https://pastebin.com/J0udhGX8

That's the report back

Looks like the driver version is up to date and vulkan works fine. We tried to reproduce this on Radeon VII and the same driver version, but the encoding was successful. I sent the information to the amf development team. I'll wait for their answer and come back.

OvchinnikovDmitrii · 2019-09-16T09:00:07Z

@sr55 Could you also provide this?

Output of commands:
apt list --installed >software.txt
sudo lshw >harware.txt
executable file and small sample video with error

sr55 · 2019-09-17T18:46:44Z

I've asked the user to join us here for feedback.

bradleysepos · 2019-09-17T21:56:12Z

User reports the following with invocation of HandBrake latest on Arch Linux:

0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-17 15:51:07 50B727C0 [AMFContextImpl]   Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
[15:51:07] VCE: AMF failed to initialise on the given Vulkan device.
 
Cannot load libnvidia-encode.so.1
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-17 15:51:07 50B727C0 [AMFContextImpl]   Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-17 15:51:07 50B727C0 [AMFContextImpl]   Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(716):Assertion failed:vkCreateDevice() failed, Error=-7
0119-08-17 15:51:07 50B727C0 [AMFDeviceVulkanImpl]   Error: ../../../../../runtime/src/core/DeviceVulkanImpl.cpp(406):AMF_ERROR 1 : AMF_FAIL: CreateDeviceAndFindQueues() failed
0119-08-17 15:51:07 50B727C0 [AMFContextImpl]   Error: ../../../../../runtime/src/core/ContextImpl.cpp(797):AMF_ERROR 1 : AMF_FAIL: pDeviceVulkan->Init(pVulkanDevice)
[15:51:07] hb_init: starting libhb thread
[15:51:07] thread 7f8247954700 started ("libhb")
Missing input device. Run HandBrakeCLI --help for syntax.

bradleysepos · 2019-09-17T21:59:15Z

User reported hardware: https://pastebin.com/WZVBhcz9

And software: https://pastebin.com/Z7g7gwyV

OvchinnikovDmitrii · 2019-09-23T07:15:18Z

User reported hardware: https://pastebin.com/WZVBhcz9

And software: https://pastebin.com/Z7g7gwyV

There are 2 versions of vulkan driver in the software list:

lib32-vulkan-amdgpu-pro 19.30_855429-1 = the correct driver
lib32-Vulcan-Radeon 19.1.7-1-open source Mesa driver

It is possible that the wrong driver is loading and causing an error.

ghost · 2019-09-25T21:50:45Z

I was the one with the VII. Seems like the drivers was the problem all along. I did uninstall the open source Vulkan drivers and encoding in h.264 doesn't spit out any errors and the output seems fine.

yurtesen · 2019-11-15T00:50:00Z

I was thinking of testing VCE. Do the CLI option visible in help output when VCE support is enabled? It is not mentioned anywhere in Handbrake documentation.

bradleysepos · 2019-11-15T16:18:46Z

VCE on Linux is experimental. You can enable it when building from source by passing --enable-vce to configure.

yurtesen · 2019-11-16T00:56:07Z

@bradleysepos I was trying to figure out if there is an option to enable it when running HandBrakeCLI like an encoder option etc. Because documentation and most posts on internet only mention using the Handbrake GUI to enable it. Hmm?

bradleysepos · 2019-11-16T01:10:54Z

It depends what you mean by enable. VCE support must be enabled at configure time, then when using HandBrakeCLI you must select the encoder you want to use with --encoder. Run HandBrakeCLI --help for a list of encoders.

yurtesen · 2019-11-16T15:24:24Z

@bradleysepos yes, but I enabled it yet I see nothing in the --help output

I built it with

# ./configure --disable-numa --disable-gtk --disable-qsv --disable-nvenc --enable-vce --enable-fdk-aac

and I see:

-------------------------------------------------------------------------------
Build system:       x86_64-pc-linux-gnu
Host system:        x86_64-pc-linux-gnu
Target platform:    linux
Harden:             False
Sandbox:            False (not supported on target platform)
Enable FDK-AAC:     True
Enable FFmpeg AAC:  True  (required on target platform)
Enable NVENC:       False
Enable QSV:         False
Enable VCE:         True
-------------------------------------------------------------------------------
Build is configured!

But nothing in the encoder section of the binary which is built!

   -e, --encoder <string>  Select video encoder:
                               x264
                               x264_10bit
                               x265
                               x265_10bit
                               x265_12bit
                               mpeg4
                               mpeg2
                               VP8
                               VP9
                               theora

I mean nothing related to VCE is in encoder section?

bradleysepos · 2019-11-16T15:26:46Z

Hmm, I believe it should be listed there if everything's functional.

Can you do a quick encode with any settings you want, and provide the output here? Would help to see what the CLI is seeing.

sr55 · 2019-11-16T15:28:12Z

If it's not listed, it means the drivers are not setup correctly.
There won't be any logging when it's not available.

yurtesen · 2019-11-16T16:46:18Z

@sr55 you are right, I seem to be missing some libraries that handbrake is looking at startup. It could come handy if there was a way to report what was missing to user. Anyway, I ran out of time now, but I will try this later perhaps next year again. Thanks for the help!

sr55 · 2019-11-16T17:23:47Z

It's enough of a pain on Linux that it's not practical I'm afraid. It's not even as simple as having the correct driver. You also need to make sure the open source one isn't loading

It also gets quite messy between distros.

yurtesen · 2019-11-17T15:40:52Z

@sr55 It was just a suggestion as it was not very straightforward to figure out why I did not see the hardware encoding option. If it is not possible then it is not possible....

I thought handbrake already had some checks as you guys put it adequately it only shows the encoder if the driver is installed properly. I also ran it with strace and it was looking for libamfrt64 at startup.

Anyway, thanks for the help. I will return back to trying this if and when I install the amdgpu-pro driver.

bradleysepos assigned sr55 and jstebbins Jun 18, 2019

sr55 added the Enhancement label Jul 12, 2019

sr55 added this to the 1.3.0 milestone Jul 12, 2019

sr55 added the Upstream Enhancement label Jul 12, 2019

bradleysepos modified the milestones: 1.3.0, Unscheduled Aug 5, 2019

bradleysepos mentioned this pull request Aug 26, 2019

AMD VCE - Ubuntu 19.04 #2277

Closed

bradleysepos modified the milestones: Unscheduled , 1.3.0 Aug 26, 2019

VCE: Vulkan support on linux.

67bf399

bradleysepos force-pushed the amf_linux_encoder branch from 818f84b to 67bf399 Compare August 28, 2019 17:10

bradleysepos merged commit 67bf399 into HandBrake:master Aug 28, 2019

Added linux support for amf encoder through vulkan. #2151

Added linux support for amf encoder through vulkan. #2151

Uh oh!

Conversation

OvchinnikovDmitrii commented Jun 18, 2019

Uh oh!

jstebbins commented Jun 18, 2019

Uh oh!

OvchinnikovDmitrii commented Jun 18, 2019

Uh oh!

jstebbins commented Jun 18, 2019

Uh oh!

sr55 commented Jul 12, 2019

Uh oh!

bradleysepos commented Aug 5, 2019

Uh oh!

OvchinnikovDmitrii commented Aug 8, 2019

Uh oh!

OvchinnikovDmitrii commented Aug 28, 2019

Uh oh!

bradleysepos commented Aug 28, 2019

Uh oh!

jstebbins commented Aug 28, 2019

Uh oh!

bradleysepos commented Aug 28, 2019

Uh oh!

sr55 commented Sep 3, 2019

Uh oh!

OvchinnikovDmitrii commented Sep 4, 2019

Uh oh!

sr55 commented Sep 4, 2019

Uh oh!

sr55 commented Sep 6, 2019

Uh oh!

OvchinnikovDmitrii commented Sep 9, 2019

Uh oh!

OvchinnikovDmitrii commented Sep 16, 2019

Uh oh!

sr55 commented Sep 17, 2019

Uh oh!

bradleysepos commented Sep 17, 2019

Uh oh!

bradleysepos commented Sep 17, 2019

Uh oh!

OvchinnikovDmitrii commented Sep 23, 2019

Uh oh!

ghost commented Sep 25, 2019

Uh oh!

yurtesen commented Nov 15, 2019

Uh oh!

bradleysepos commented Nov 15, 2019

Uh oh!

yurtesen commented Nov 16, 2019

Uh oh!

bradleysepos commented Nov 16, 2019

Uh oh!

yurtesen commented Nov 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bradleysepos commented Nov 16, 2019

Uh oh!

sr55 commented Nov 16, 2019

Uh oh!

yurtesen commented Nov 16, 2019

Uh oh!

sr55 commented Nov 16, 2019

Uh oh!

yurtesen commented Nov 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

yurtesen commented Nov 16, 2019 •

edited

Loading