Libhb vce h265 10bit #4538
Libhb vce h265 10bit #4538
Conversation
|
Hi, Thanks for the patch. Have the ffmpeg patches been submitted upstream yet? I'll review over & test over the weekend if I get a moment. |
libhb/handbrake/common.h
Outdated
| @@ -563,6 +563,7 @@ struct hb_job_s | |||
| #define HB_VCODEC_FFMPEG_VP9 0x0000080 | |||
| #define HB_VCODEC_FFMPEG_VCE_H264 0x00040000 | |||
| #define HB_VCODEC_FFMPEG_VCE_H265 0x00080000 | |||
| #define HB_VCODEC_FFMPEG_VCE_H265_10BIT 0x00080001 | |||
There was a problem hiding this comment.
HB_VCODEC_ is kind of a bit field, and each codec should be a single bit. But I'll have to reassign them anyway for the VP9 10 bit pull request, so let's wait a bit to fix this.
I have send these patches to ffmpeg-devel(https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7411) |
|
Validated on Windows. Seems to work quite nicely. If the cosmetic issue mention above is fixed, I'm happy for this to go in. |
|
Looks like we may need a quick resolve on this PR as well please. |
Thank you for the positive feedback! I corrected the cosmetic issues in the encoder registration. What to do with "HB_VCODEC_FFMPEG_VCE_H265_10 BIT 0x00080001" ? have the values already been reassigned?( for the VP9 10 beat pull request) |
|
They will in #4578 , which should be merged soon after a bit of testing. |
|
#4578 has been merged, if you can rebase it and move the pixel format entry to encavcodec.c it should be good to go. |
# Conflicts: # libhb/common.c # libhb/encavcodec.c # libhb/handbrake/common.h
OvchinnikovDmitrii
force-pushed
the
libhb_vce_h265_10bit
branch
from
b36cdc1
to
16e4192
Compare
Thanks! I rebased and moved the definition vce_pix_formats_10bit. |
|
Tested on Windows and merged, thanks! |
Description of Change:
Added H.265 10 bit(AMD VCE) encoder. issue - #4537
Test on: