Move HNKImageViewEntity to its own file #24

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@ventayol

This is change allows to use HNKImageViewEntity outside the UIImageView+Haneke files. With this change the users can create his own categories. We are using it to use Haneke with UIButton.

Aleix Ventayol added some commits May 26, 2014
@ventayol ventayol changed the title from Move HNKImageViewEntity to his own file to Move HNKImageViewEntity to its own file May 26, 2014
@hpique
Member
hpique commented May 27, 2014

Thanks @ventayol!

I have a very specific idea of how to extract some of the logic of the UIImageView category into remote and disk entity (sub)classes, which would simplify implementing other categories for other UI components with images (such as UIButton).

What I'm thinking of doing doesn't exactly match your pull, so I'm afraid I won't be able to merge it. I'll leave the pull open in the meantime as it might be interesting to others who are thinking of creating their own entity classes.

@ventayol

@hpique I'm sure your solution will be better than mine, meanwhile it's great that you leave this pull request open so if anyone else needs to use haneke with other UI components can use it.

@hpique
Member
hpique commented Aug 21, 2014

Closing this PR as we now have a UIButton+Category in Haneke 1.0.

@hpique hpique closed this Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment