Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove query part of URL in getting pathExtension at MD5Filename #270

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
2 participants
@banjun
Copy link
Contributor

commented Jan 7, 2016

fixes #199

NSString#pathExtension contains query part for URLString. (e.g. ext = "jpg?bar" for "foo.jpg?bar".)
NSURL#pathExtension handles this kind of URLString.

hpique added a commit that referenced this pull request Jan 7, 2016

Merge pull request #270 from banjun/fix-long-filename-for-url-with-query
remove query part of URL in getting pathExtension at MD5Filename

@hpique hpique merged commit 138a8fc into Haneke:master Jan 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hpique

This comment has been minimized.

Copy link
Member

commented Jan 7, 2016

Awesome catch @banjun!

@banjun

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2016

thanks

@banjun banjun deleted the banjun:fix-long-filename-for-url-with-query branch Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.