Cache results of the IsBatchingAvaiable method per connection type

HangfireIO · Feb 18, 2019 · 6dc93e8 · 6dc93e8 · burningice2866 · Feb 18, 2019
1 parent 4748d7e
commit 6dc93e8
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 32 deletions.
diff --git a/src/Hangfire.Core/Server/DelayedJobScheduler.cs b/src/Hangfire.Core/Server/DelayedJobScheduler.cs
@@ -15,6 +15,7 @@
 // License along with Hangfire. If not, see <http://www.gnu.org/licenses/>.
 
 using System;
+using System.Collections.Concurrent;
 using Hangfire.Annotations;
 using Hangfire.Common;
 using Hangfire.Logging;
@@ -72,6 +73,7 @@ public class DelayedJobScheduler : IBackgroundProcess
         private static readonly int BatchSize = 1000;
 
         private readonly ILog _logger = LogProvider.For<DelayedJobScheduler>();
+        private readonly ConcurrentDictionary<Type, bool> _isBatchingAvailableCache = new ConcurrentDictionary<Type, bool>();
 
         private readonly IBackgroundJobStateChanger _stateChanger;
         private readonly TimeSpan _pollingDelay;
@@ -201,25 +203,30 @@ private void EnqueueBackgroundJob(BackgroundProcessContext context, IStorageConn
             }
         }
 
-        private static bool IsBatchingAvailable(IStorageConnection connection)
+        private bool IsBatchingAvailable(IStorageConnection connection)
         {
-            if (connection is JobStorageConnection storageConnection)
-            {
-                try
-                {
-                    storageConnection.GetFirstByLowestScoreFromSet(null, 0, 0, 1);
-                }
-                catch (ArgumentNullException ex) when (ex.ParamName == "key")
-                {
-                    return true;
-                }
-                catch (Exception)
+            return _isBatchingAvailableCache.GetOrAdd(
+                connection.GetType(),
+                type =>
                 {
-                    //
-                }
-            }
+                    if (connection is JobStorageConnection storageConnection)
+                    {
+                        try
+                        {
+                            storageConnection.GetFirstByLowestScoreFromSet(null, 0, 0, 1);
+                        }
+                        catch (ArgumentNullException ex) when (ex.ParamName == "key")
+                        {
+                            return true;
+                        }
+                        catch (Exception)
+                        {
+                            //
+                        }
+                    }
 
-            return false;
+                    return false;
+                });
         }
 
         private T UseConnectionDistributedLock<T>(JobStorage storage, Func<IStorageConnection, T> action)

diff --git a/src/Hangfire.Core/Server/RecurringJobScheduler.cs b/src/Hangfire.Core/Server/RecurringJobScheduler.cs
@@ -15,6 +15,7 @@
 // License along with Hangfire. If not, see <http://www.gnu.org/licenses/>.
 
 using System;
+using System.Collections.Concurrent;
 using Hangfire.Annotations;
 using Hangfire.Client;
 using Hangfire.Common;
@@ -66,6 +67,7 @@ public class RecurringJobScheduler : IBackgroundProcess
         private static readonly int BatchSize = 1000;
 
         private readonly ILog _logger = LogProvider.For<RecurringJobScheduler>();
+        private readonly ConcurrentDictionary<Type, bool> _isBatchingAvailableCache = new ConcurrentDictionary<Type, bool>();
 
         private readonly IBackgroundJobFactory _factory;
         private readonly IStateMachine _stateMachine;
@@ -362,25 +364,30 @@ private bool UseConnectionDistributedLock(JobStorage storage, Func<IStorageConne
             return false;
         }
 
-        private static bool IsBatchingAvailable(IStorageConnection connection)
+        private bool IsBatchingAvailable(IStorageConnection connection)
         {
-            if (connection is JobStorageConnection storageConnection)
-            {
-                try
+            return _isBatchingAvailableCache.GetOrAdd(
+                connection.GetType(),
+                type =>
                 {
-                    storageConnection.GetFirstByLowestScoreFromSet(null, 0, 0, 1);
-                }
-                catch (ArgumentNullException ex) when (ex.ParamName == "key")
-                {
-                    return true;
-                }
-                catch (Exception)
-                {
-                    //
-                }
-            }
+                    if (connection is JobStorageConnection storageConnection)
+                    {
+                        try
+                        {
+                            storageConnection.GetFirstByLowestScoreFromSet(null, 0, 0, 1);
+                        }
+                        catch (ArgumentNullException ex) when (ex.ParamName == "key")
+                        {
+                            return true;
+                        }
+                        catch (Exception)
+                        {
+                            //
+                        }
+                    }
 
-            return false;
+                    return false;
+                });
         }
     }
 }