Add pins in BNF to improve parsing performance
#932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
requested review from
PHPirates,
HannahSchellekens and
stenwessel
as code owners
PHPirates
added
the
enhancement
|
All compilation errors are caused by manually-edited generated files. Will do some git-reverts. |
|
@HannahSchellekens Please resolve merge conflicts. FWIW I tested this PR in the last alpha builds and didn't notice any problems. |
# Conflicts: # src/nl/hannahsten/texifyidea/folding/LatexEnvironmentFoldingBuilder.kt
I have resolved merge conflicts. |
All usage was already delegated to the PsiFile.referencedFileSet extension method, so changing that method to use the ReferencedFileSetService was enough for it to take effect.
src/nl/hannahsten/texifyidea/inspections/latex/LatexAvoidEqnarrayInspection.kt
Outdated
Show resolved
Hide resolved
|
Fixed, please take a look @HannahSchellekens @PHPirates |
HannahSchellekens
approved these changes
Jul 3, 2019
|
Travis failing, oh no |
|
Should be fixed by my force-push |
|
Merged master |
PHPirates
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Added some
{ pin=1 }or{ pin=2 }to proper BNF rules to improve parsing performance and fault tolerance.Changes
Regenerate parsers (in awe that some generated files are manually edited).
Backwards incompatible changes
Some Psi APIs are now returning nullable because the parser is now fault-tolerant: it also parses incomplete code as incomplete ASTs. Parsing errors will be displayed but code analysis can still run.