Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `pin`s in BNF to improve parsing performance #932

Open
wants to merge 5 commits into
base: master
from

Conversation

@ice1000
Copy link
Contributor

commented Jun 18, 2019

Additions

Added some { pin=1 } or { pin=2 } to proper BNF rules to improve parsing performance and fault tolerance.

Changes

Regenerate parsers (in awe that some generated files are manually edited).

Backwards incompatible changes

Some Psi APIs are now returning nullable because the parser is now fault-tolerant: it also parses incomplete code as incomplete ASTs. Parsing errors will be displayed but code analysis can still run.

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

All compilation errors are caused by manually-edited generated files. Will do some git-reverts.

@ice1000 ice1000 force-pushed the ice1000:pin branch from f19e35a to 1aa61c8 Jun 18, 2019

@HannahSchellekens HannahSchellekens added this to the b0.6.7 milestone Jun 18, 2019

@ice1000 ice1000 force-pushed the ice1000:pin branch from 1c620df to 1e678b2 Jun 18, 2019

@PHPirates

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

@HannahSchellekens Please resolve merge conflicts.

FWIW I tested this PR in the last alpha builds and didn't notice any problems.

Merge remote-tracking branch 'origin/master' into pin
# Conflicts:
#	src/nl/hannahsten/texifyidea/folding/LatexEnvironmentFoldingBuilder.kt
@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@HannahSchellekens Please resolve merge conflicts.

FWIW I tested this PR in the last alpha builds and didn't notice any problems.

I have resolved merge conflicts.

@HannahSchellekens
Copy link
Member

left a comment

Looking good, and thanks for the effort! Just one little formatting change which shouldn't be much of an issue.

Edit: for what I've tested it seems to work flawlessly.

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Fixed, please take a look @HannahSchellekens @PHPirates

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Travis failing, oh no

@ice1000 ice1000 force-pushed the ice1000:pin branch from 94241c2 to 34cb28f Jul 3, 2019

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Should be fixed by my force-push

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Merged master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.