Improved code of PsiContainer #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
requested review from
PHPirates,
HannahSchellekens and
stenwessel
as code owners
ice1000
reviewed
Jun 18, 2019
| element = element.nextSibling | ||
| } | ||
| } | ||
| fun elements() = generateSequence(start) { it.nextSibling?.takeIf { it != end } } |
There was a problem hiding this comment.
Will generate a lazy sequence, end when it.nextSibling is null or it == end
| override fun accept(visitor: PsiElementVisitor) = iterateElements { | ||
| start.accept(visitor) | ||
| } | ||
| override fun accept(visitor: PsiElementVisitor) = elements().forEach { it.accept(visitor) } |
HannahSchellekens
approved these changes
Jun 18, 2019
Agree on everything. Let's say you'll learn a lot in a few years ;)
HannahSchellekens
added
the
enhancement
|
Any updates? |
|
Please resolve merge conflicts. |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is how we write codes in Kotlin.
Additions
N/A, but possibly a bug-fix, will comment soon to explain
Changes
N/A
Backwards incompatible changes
N/A