Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCausalSNPs() doesn't identify single causal SNP #13

Closed
SarahNadeau opened this issue May 6, 2019 · 2 comments
Closed

getCausalSNPs() doesn't identify single causal SNP #13

SarahNadeau opened this issue May 6, 2019 · 2 comments

Comments

@SarahNadeau
Copy link

@SarahNadeau SarahNadeau commented May 6, 2019

getCausalSNPs() does not identify which SNP is causal when only a single causal SNP is specified. To demonstrate the problem:

getCausalSNPs(NrCausalSNPs = 1, ...) gives:
[,1]
ID_1 0
ID_2 0
ID_3 0

while getCausalSNPs(NrCausalSNPs = 2, ...) gives the more helpful:
SNP_6 SNP_7
ID_1 0 0
ID_2 0 0
ID_3 0 0

I believe this problem is a result of this line in the getCausalSNPs function:
causalSNPs <- genotypes$genotypes[, sort(sample(ncol(genotypes$genotypes),
NrCausalSNPs))]

@HannahVMeyer
Copy link
Owner

@HannahVMeyer HannahVMeyer commented May 13, 2019

Hi Sarah,

thank you for pointing this out. I have fixed the issue now.

Hannah

@SarahNadeau
Copy link
Author

@SarahNadeau SarahNadeau commented May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.