Skip to content

Some performance workarounds for Elden Ring #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

HansKristian-Work
Copy link
Owner

No description provided.

Elden Ring in particular spam frees and allocates command pools despite
this being a very bad idea.

Add a simple 8-entry cache which seems to take care of it.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Normal behaving apps should not benefit from any of this.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Copy link
Collaborator

@doitsujin doitsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to hide this behind an option? I suppose this might eat some host/hvv memory
in the worst case, but I don't expect well-behaved apps to destroy (m)any command pools in the first place.

@HansKristian-Work HansKristian-Work merged commit f39ece9 into master Feb 25, 2022
@HansKristian-Work HansKristian-Work deleted the command-pool-recycle branch February 25, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants