SSBO support for raw and structured buffers #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
HansKristian-Work
requested changes
Oct 16, 2020
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
doitsujin
force-pushed
the
raw-ssbo
branch
2 times, most recently
from
d620190
to
2a95f3a
Compare
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
This will no longer be exclusive to constant buffer views. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
This is no longer performance-critical, so in order to simplify changing the binding model, remove hard-coded descriptor set numbers and instead look them up based on the requested descriptor properties. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
We won't necessarily have a view once we support raw SSBOs. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
This will allow us to use the same bindless descriptor set for different types of descriptor ranges. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Buffer views do not necessarily cover the entire resource, so we should not spawn more workgroups than necessary to clear the view. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
May improve performance since the UAV counter buffer is stored in uncached memory. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de>
HansKristian-Work
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a path to use untyped storage buffers for raw/structured buffers, rather than texel buffers, in an attempt to improve the situation for #266. This decision is made on a per-view basis depending on alignment requirements.
Currently disabled as it regresses some DXIL tests. Tested in Control, Shadow of the Tomb Raider, Ghostrunner Demo, and Resident Evil 3.