From fd0ea47dee5d08e9d34ec27dbb4aae1f7c37633c Mon Sep 17 00:00:00 2001 From: Nyholm Date: Fri, 17 Sep 2021 16:28:28 -0700 Subject: [PATCH 1/2] Remove Message::noContent() --- CHANGELOG.md | 6 +++++- src/Model/Message.php | 5 ----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a312a6a..1ec07be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release. +The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release. ## 0.3.0 @@ -13,6 +13,10 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee - Content-Type depends on the serializer used or the second parameter for `ResponseFactory`. - Removed `final` keyword from models +### Removed + +- Message::noContent() + ## 0.2.0 ### Added diff --git a/src/Model/Message.php b/src/Model/Message.php index bcf218f..342a4c8 100644 --- a/src/Model/Message.php +++ b/src/Model/Message.php @@ -28,9 +28,4 @@ public static function accepted(string $message = 'Accepted'): self { return new self($message, 202); } - - public static function noContent(string $message = 'No Content'): self - { - return new self($message, 204); - } } From e1f0b8c77164fa01daf2d6ce19e48e64105a4f55 Mon Sep 17 00:00:00 2001 From: Nyholm Date: Fri, 17 Sep 2021 16:29:38 -0700 Subject: [PATCH 2/2] Remove test --- tests/Unit/Model/MessageTest.php | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/tests/Unit/Model/MessageTest.php b/tests/Unit/Model/MessageTest.php index fde889d..b4f80b3 100644 --- a/tests/Unit/Model/MessageTest.php +++ b/tests/Unit/Model/MessageTest.php @@ -56,19 +56,4 @@ public function testAcepted(): void $message->getPayload() ); } - - public function testNoContent(): void - { - $message = Message::noContent('someTitle'); - - self::assertEquals(204, $message->getHttpStatusCode()); - self::assertEquals( - [ - 'meta' => [ - 'message' => 'someTitle', - ], - ], - $message->getPayload() - ); - } }