SFX Editor - Feedback/Changes

[garrettjoecox]

The first iteration of the SFX Editor is a good starting point, but still lacking in ways. This issue is for recording feedback/requests related to the SFX Editor.

Features missing:

• Support for custom audio files
• Shuffling music/sfx outside of their respective category
• "Ear friendly" randomization mode
• Linking SFX settings to randomizer seed to be shared
• Support for looping songs that aren't normally looping

SFX Missing:

• Will add to this list over time

SFX To remove:

• Final credits sequence

[jbodner09]

I'd consider custom audio files thoroughly into "mod" territory, if for no other reason than the existing files from, for example, https://github.com/DaruniasJoy/OoT-Custom-Sequences, can't be used as-is and need to be converted, therefore making this bullet point out of scope at least for vnext of the sound editor.

[lilacLunatic]

• Seal of the Six Sages probably shouldn't be under background music, as I came to learn it doesn't actually loop. It's too long to be a fanfare, so maybe it doesn't have a home in the SFX editor and should be (re)set to "don't shuffle"
• Ganon's Castle Bridge seems to be broken, at least in the Preview button, and it should probably be a fanfare instead.
• I hold my stance that battle music should be shuffled with background/event music.

[garrettjoecox]

Ganon's Castle Bridge seems to be broken, at least in the Preview button

Are you on the latest commit? Preview button is working on my end

[garrettjoecox]

Changes:

Features missing:
+- Support for looping songs that aren't normally looping

SFX To remove:
+- Final credits sequence

[briaguya-ai]

• Seal of the Six Sages probably shouldn't be under background music, as I came to learn it doesn't actually loop. It's too long to be a fanfare, so maybe it doesn't have a home in the SFX editor and should be (re)set to "don't shuffle"

i think we should be able to randomize what gets played instead of "Seal of the Six Sages," but it shouldn't be in the pool of looping bgm to shuffle

[briaguya-ai]

@garrettjoecox i think we've probably made enough progress around this to split it out into specific issues, i'll leave it open for now though

[briaguya-ai]

closing this one, it's been split into smaller issues now