Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetics Editor v3 - Known issues and TODOs #2113

Open
2 of 15 tasks
garrettjoecox opened this issue Dec 7, 2022 · 7 comments
Open
2 of 15 tasks

Cosmetics Editor v3 - Known issues and TODOs #2113

garrettjoecox opened this issue Dec 7, 2022 · 7 comments
Labels
epic a bunch of bugs/features grouped together because they're related somehow

Comments

@garrettjoecox
Copy link
Contributor

garrettjoecox commented Dec 7, 2022

Anyone is able to take these on, if you need any help or pointers on adding additional cosmetics reach out to me on discord @ProxySaw

Todo List

  • Clean up UI at the top of the window to be a bit cleaner
  • Rainbow slider Tweaks
    • Reverse direction, so that faster is to the right, slower to the left
    • Describe what the number does (eg: full color cycle every x seconds)
    • Allow for even slower cycling
  • Rainbow color "popping" every 10 to 20 seconds (this is a me being bad at math thing I think)
  • Missing cosmetics from v2
    • Title screen fire
    • Magic effects
  • Additional cosmetics
    • Health fairy color
    • Hookshot
    • Gradient trail colors

Known issues

  • Some textures can only be as bright as the original color, notably link's hair, boots and gloves.
  • Start/A/B color previews should respect color scheme (just the previews arent, the in game colors are)
  • Shop cursor flashes for some colors
  • In some cases when there are two colors to customize for an item, if the colors are too different(?) there is some weird clamping happening turning parts of the color black. This happens with the master sword when it's in the pedestal and some of the magic effects. This could be related to the reason saria's song has black color clamping in it's texture. I have verified this issue was introduced here
  • Crash when re-sizing link on file select menu
@garrettjoecox garrettjoecox mentioned this issue Dec 7, 2022
25 tasks
@Gamer1758
Copy link

Gamer1758 commented Dec 9, 2022

navi doesnt rainbow properly, she does change on reloads and soft/hard targeting, the target arrow(s) do rainbow properly.

@garrettjoecox
Copy link
Contributor Author

Broken biggoron's sword doesn't match biggoron's sword

@garrettjoecox
Copy link
Contributor Author

Sword trails don't properly reset until scene reload

@garrettjoecox
Copy link
Contributor Author

Changing various colors in the cosmetics editor the game will crash on Wii U

@garrettjoecox
Copy link
Contributor Author

Game crashes for windows DEBUG when changing cosmetics that involve DList patching the displayListEnd() command

@briaguya-ai briaguya-ai added the epic a bunch of bugs/features grouped together because they're related somehow label Dec 22, 2022
@briaguya-ai
Copy link
Contributor

i think the

Allow for even slower cycling

part would be best addressed by standardizing the rainbow rate across all interpolation values. Since it updates every frame, running rainbow at high frame rates (like 144+ fps) makes it really fast.

@briaguya-ai
Copy link
Contributor

might be worth looking into simplifying the rainbow calculation by just changing the Hue value in an HSL color and then getting the RGB from that (then every frame we'd just be doing a currentHue + hueStep % 360 (or 2PI) then feeding it into something like https://web.archive.org/web/20030820171808/https://astronomy.swin.edu.au/~pbourke/colour/hsl/

just a thought, i tried digging into the current rainbow code a little and it's a bit hard to parse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic a bunch of bugs/features grouped together because they're related somehow
Projects
None yet
Development

No branches or pull requests

3 participants