Skip to content

Cosmetic Editor v3 #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 9, 2022
Merged

Cosmetic Editor v3 #1898

merged 25 commits into from
Dec 9, 2022

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Nov 3, 2022 •
edited by github-actions bot
Loading

If you have any feedback please post it in the discord thread. Will keep this PR up to date with the things remaining.

Changes:

  • Completely redone backend and frontend to the cosmetics editor
  • Ability to adjust speed of rainbow
  • Toggle for advanced mode, for the people who like to go nuts
  • Lots of new cosmetics supported, including but no limited to:
    • Link's Hair and linens
    • Swords, Bow, other equipment
    • Hearts/Magic in world match UI
    • Skulltulas
    • Rupees
    • More on the way
  • "Silly" tab with a few random things, will add more here over time.

Screen Shot 2022-11-02 at 11 26 41 PM

Todo:

  • Clean up UI at the top of the window
  • Start/A/B color previews should respect color scheme (just the previews arent, the in game colors are)
  • Shop cursor flashes for some colors
  • Some colors are negatively affected by the color clamping introduced here
  • Reverse rainbow speed slider
  • Parity with v2
    • Magic effects
    • Trails
    • Spin attack
    • Navi
  • Moar cosmetics
    • Hookshot
    • Slingshot
    • Bow
    • Swords
  • Sword hilts not always applied
  • master sword not changed in ganon fight cutscene
  • LUS Changes need to be made upstream and will block this from being merged for the time being
  • Reset per box/tab?
  • Better math for rupee colors, currently they are a bit too white when randomized
  • Cosmetics state not reading from CVar correctly on load
  • Randomize button in simple mode should affect some things in advanced mode based on the result
  • Slower rainbow mode
  • Synced rainbow mode
  • Wallet rupee color issue

Build Artifacts

@garrettjoecox garrettjoecox added the do not merge Not ready or not valid changes label Nov 3, 2022
@PurpleHato PurpleHato mentioned this pull request Nov 8, 2022
Closed
@lilacLunatic lilacLunatic mentioned this pull request Nov 9, 2022
Closed
@briaguya-ai
Copy link
Contributor

briaguya-ai commented Nov 14, 2022 •
edited
Loading

needs Kenix3/libultraship#21 and Kenix3/libultraship#25

@garrettjoecox garrettjoecox force-pushed the cosmetics-pass branch 6 times, most recently from bacc817 to 3bc3ac0 Compare November 21, 2022 20:13
@garrettjoecox garrettjoecox force-pushed the cosmetics-pass branch 3 times, most recently from dbdb72a to 0668d4a Compare November 26, 2022 23:21
@garrettjoecox garrettjoecox force-pushed the cosmetics-pass branch 2 times, most recently from 66924f5 to 5c14761 Compare December 1, 2022 17:18
PurpleHato
PurpleHato reviewed Dec 1, 2022
View reviewed changes
@garrettjoecox garrettjoecox force-pushed the cosmetics-pass branch 4 times, most recently from d96ac45 to 450ddaf Compare December 7, 2022 18:44
@garrettjoecox garrettjoecox removed the do not merge Not ready or not valid changes label Dec 7, 2022
@garrettjoecox
Copy link
Contributor Author

Added remaining issues/todos to #2113

briaguya-ai
briaguya-ai reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is great! so many places are easier to understand than they were before, thank you so much for doing this!

i left quite a few comments in here, i don't think any of them are things that i'd consider to be required changes before merging this, but there are a few places that could benefit from clarificaiton

@garrettjoecox garrettjoecox changed the title [WIP] Cosmetic Editor v3 Cosmetic Editor v3 Dec 8, 2022
briaguya-ai
briaguya-ai approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely incredible documentation as of the latest commits, just amazing

i'm approving, but i'm going to mark this as do not merge until we test out the time stuff on switch and wii u (or at least cemu)

there's also one tiny comment i left unresolved but that's like a 4 word change

super exciting stuff!

@briaguya-ai briaguya-ai added the do not merge Not ready or not valid changes label Dec 8, 2022
@briaguya-ai
Copy link
Contributor

marked as do not merge until we get verification that the time stuff functions properly on all platforms

@briaguya-ai
Copy link
Contributor

briaguya-ai commented Dec 8, 2022 •
edited
Loading

verified working on wii u (cemu), just need to verify on switch and we should be good to go!

@briaguya-ai briaguya-ai added merge ready and removed do not merge Not ready or not valid changes labels Dec 9, 2022
@briaguya-ai briaguya-ai merged commit 274c12f into HarbourMasters:develop Dec 9, 2022
@garrettjoecox garrettjoecox mentioned this pull request Dec 12, 2022
Closed
@lilacLunatic lilacLunatic mentioned this pull request Dec 30, 2022
Open
@garrettjoecox garrettjoecox deleted the cosmetics-pass branch January 23, 2023 20:09
@briaguya-ai briaguya-ai mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PurpleHato PurpleHato PurpleHato left review comments

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjoecox @briaguya-ai @PurpleHato