Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rando: Entrance Tracker v1 #2005

Merged
merged 17 commits into from
Dec 7, 2022
Merged

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Nov 23, 2022

This adds an entrance tracker for entrance rando.

Features include:

  • Entrances grouped by area or entrance type
  • Entrances sorted by "To" or "From" (source -> override or override -> source)
  • A search field leveraging meta tags for searching full names, acronyms, and types, with clear button
  • Collapse All/Expand All buttons for toggling the trees
  • Toggle-able auto scroll for the "current" scene you are in
  • Toggle-able highlighting for entrances that are "available" from the current scene
  • Toggle-able highlighting for the last entrance you came from

The tracker only displays shuffled entrances, and as such wont display anything for a non-entrance rando seed or vanilla saves.

The tracker settings are contained within a tree at the top of the tracker.

Discovered entrances are saved in the SohStats struct using integer division and bit mapping into an array. This is for a reduced structure in the save json and to allow saving/checking an entrance was discovered without looping.

I welcome any feedback, especially UI/UX 😃

(Most of the tracker information was taken from the 3ds rando entrance tracker)

image
image
image

Build Artifacts

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is looking really good! looks like there's a ton of logic in here, and it's great to hear that testing has been going well.

i left quite a lot of comments in there, mostly questions and small suggestions for places where having comments explaining the logic would be helpful for readability.

i'm sure some of the changes i suggested could be considered out of scope, so don't feel obligated to address everything

soh/soh/Enhancements/randomizer/randomizer_entrance.c Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance.c Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance.c Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance.c Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer_grotto.c Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer_grotto.c Outdated Show resolved Hide resolved
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super close to ready to go! Thanks for addressing the comments! Just a few renaming suggestions.

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@briaguya-ai briaguya-ai merged commit 8337e4e into HarbourMasters:develop Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants