-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rando: Entrance Tracker v1 #2005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this is looking really good! looks like there's a ton of logic in here, and it's great to hear that testing has been going well.
i left quite a lot of comments in there, mostly questions and small suggestions for places where having comments explaining the logic would be helpful for readability.
i'm sure some of the changes i suggested could be considered out of scope, so don't feel obligated to address everything
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super close to ready to go! Thanks for addressing the comments! Just a few renaming suggestions.
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
This adds an entrance tracker for entrance rando.
Features include:
The tracker only displays shuffled entrances, and as such wont display anything for a non-entrance rando seed or vanilla saves.
The tracker settings are contained within a tree at the top of the tracker.
Discovered entrances are saved in the
SohStats
struct using integer division and bit mapping into an array. This is for a reduced structure in the save json and to allow saving/checking an entrance was discovered without looping.I welcome any feedback, especially UI/UX 😃
(Most of the tracker information was taken from the 3ds rando entrance tracker)
Build Artifacts