Entrance Rando v2 #2071
Merged
Entrance Rando v2 #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
entranceRandoV2
branch
from
6c8e745 to
f5259ff
Compare
briaguya-ai
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
This looks great! Assuming testing went as well as you say it did @Archez let's 
PurpleHato
reviewed
Dec 6, 2022
Archez
commented
Dec 6, 2022
Archez
commented
Dec 6, 2022
|
Added French translations, thanks @PurpleHato |
dcvz
approved these changes
Dec 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work for entrance randomizer, bringing in Overworld Spawns, Warp Songs, Owl Drops, and with mixed pools and decoupled entrances.
Features:
Most of the code is syncing the related changes from 3ds rando upstream for the entrance logic. The spoiler log is modified to write out decoupled entrance names in the
entranceMap.The new features didn't require much extra work to pull off, taking advantage of the previous entrance rando work. The logic around tracking which grotto was entered/last existed needed to be modified to account for mixed pools and overworld spaws/warp songs.
The savewarp override logic needed to be moved to the end of the init process as a spawn randomized to a grotto exit has to setup values on the respawn flags, that normally are zeroed out during init.
The warp song hint system will store and use the overridden regions hint name, otherwise if not provided (interiors or grottos) use the entrance name itself from the 3ds location code.
In randomizer settings, the options under mixed pools will disappear if mixed pools is turned off, or the corresponding entrance shuffle type isn't shuffled.
Build Artifacts