Skip to content

Conversation

@yds
Copy link
Contributor

@yds yds commented Dec 5, 2019

Fixes #3

Copy link
Member

@lattera lattera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kick_publisher_tires function will need to be updated to properly sync the symlink.

@lattera
Copy link
Member

lattera commented Dec 5, 2019

Thank you so much for the submission! I noted one change that'll need to happen. Another change is to ensure that the previous mv command's exit code needs to be checked.

Copy link
Member

@lattera lattera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do two rsyncs, one for the build artifacts (the original rsync) and the other for the symlink (upon success of the first).

@lattera lattera self-assigned this Dec 5, 2019
@yds yds requested a review from lattera December 5, 2019 23:04
@lattera
Copy link
Member

lattera commented Dec 5, 2019

Looks good now. I've merged this in locally and am running two builds on my dev server. If those two builds succeed, I'll push the local merge and deploy to production.

I really appreciate the submission and for the opportunity to use this submission to interact with the community. This is a good first submission to show how the community can improve our infrastructure in an open and trusted manner.

Copy link
Member

@lattera lattera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged this in. I made a couple changes.

@lattera
Copy link
Member

lattera commented Dec 6, 2019

I've merged this in. The changes are now live and will take affect on the next scheduled build. Thank you so much for the contribution!

@lattera lattera closed this Dec 6, 2019
@yds yds deleted the build-latest branch December 7, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support BUILD-LATEST symlink

2 participants