-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BUILD-LATEST symlink #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kick_publisher_tires
function will need to be updated to properly sync the symlink.
Thank you so much for the submission! I noted one change that'll need to happen. Another change is to ensure that the previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do two rsyncs, one for the build artifacts (the original rsync) and the other for the symlink (upon success of the first).
Looks good now. I've merged this in locally and am running two builds on my dev server. If those two builds succeed, I'll push the local merge and deploy to production. I really appreciate the submission and for the opportunity to use this submission to interact with the community. This is a good first submission to show how the community can improve our infrastructure in an open and trusted manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged this in. I made a couple changes.
I've merged this in. The changes are now live and will take affect on the next scheduled build. Thank you so much for the contribution! |
Fixes #3