Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BUILD-LATEST symlink #4

Closed
wants to merge 3 commits into from
Closed

Conversation

@yds
Copy link
Contributor

yds commented Dec 5, 2019

Fixes #3

Copy link
Member

lattera left a comment

The kick_publisher_tires function will need to be updated to properly sync the symlink.

@lattera

This comment has been minimized.

Copy link
Member

lattera commented Dec 5, 2019

Thank you so much for the submission! I noted one change that'll need to happen. Another change is to ensure that the previous mv command's exit code needs to be checked.

lib/publish.sh Show resolved Hide resolved
Copy link
Member

lattera left a comment

Do two rsyncs, one for the build artifacts (the original rsync) and the other for the symlink (upon success of the first).

lib/publish.sh Outdated Show resolved Hide resolved
@lattera lattera self-assigned this Dec 5, 2019
@yds yds requested a review from lattera Dec 5, 2019
@lattera

This comment has been minimized.

Copy link
Member

lattera commented Dec 5, 2019

Looks good now. I've merged this in locally and am running two builds on my dev server. If those two builds succeed, I'll push the local merge and deploy to production.

I really appreciate the submission and for the opportunity to use this submission to interact with the community. This is a good first submission to show how the community can improve our infrastructure in an open and trusted manner.

@lattera
lattera approved these changes Dec 6, 2019
Copy link
Member

lattera left a comment

I've merged this in. I made a couple changes.

@lattera

This comment has been minimized.

Copy link
Member

lattera commented Dec 6, 2019

I've merged this in. The changes are now live and will take affect on the next scheduled build. Thank you so much for the contribution!

@lattera lattera closed this Dec 6, 2019
@yds yds deleted the yds:build-latest branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.